Repository navigation
perf: reduce board overhead and bound engine loading - #30
Merged
Merged
Conversation
8 of 11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reduce the work needed to load and animate the board, and let Master engine startup fail and retry when an asset body stalls instead of waiting indefinitely.
a3 → a4, low qualityHigh quality preloads optional bloom on the first action and enables it during captures. Low and medium quality avoid that download. Frame telemetry retains slow active frames above 250 ms while excluding idle gaps; CI reuses the production build and checks rendering regressions.
Validation
npm run typechecknpm run lintnpm run test:bundlewhen client imports or dependencies changeCommands and results:
npm run format:check,npm run typecheck,npm run lint— passed.npm run test:unitandnpm run test:runtime— 350 tests passed, including stalled manifest/runtime bodies, abort, and retry.npm run test:budget— model, audio, and engine asset validation passed with verified local Git LFS content.npm testandnpm run test:bundle— production build, 4 HTML checks, 3 budget tests, and all 4 optional import boundaries passed.npm run test:e2e:built— 12 production checks passed, including a real Master engine move, restore, capture, undo, and local two-player turns. The opt-in 100-opening lifecycle test was skipped.tests/e2e/render-work.spec.ts— all 3 checks passed: stationary render counts, high-quality bloom selection, and failed-download fallback. The ambient lifecycle check inresilience.spec.tspassed across 120 browser frames with stable resources and active frame samples.Measurements and scope are recorded in docs/validation.md.
Visual and asset changes
No visual-design or asset-content changes are intended. Rendering and optional-effect loading changed; the browser checks above exercise those paths. No snapshots or provenance updates were needed. Required LFS content was hydrated for validation; committed assets remain unchanged.
Risk
Supply chain and security
CI now reuses its existing build and runs the rendering regressions. Dependencies, action pins, permissions, secrets, and third-party provenance are unchanged.