Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding option to specify protocols to import when using transformable type #147

Merged
merged 5 commits into from
Mar 15, 2013

Conversation

rtircher
Copy link
Contributor

@rtircher rtircher commented Feb 8, 2013

Allows to specify a attributeValueClassName similar to id<MyProtocol>
Mogenerator can now insert @protocol MyProtocol; in the machine header files. Another user info needs to be added where the key is attributeTransformableProtocols and the value is a comma separated list of the protocols used for the type. For the above example, it would just be MyProtocol as value.

@rentzsch
Copy link
Owner

Looks good. Could you please extend the Test Dir to exercise your enhancement?

I'm thinking adding a transformable attribute with a custom protocol (myTransformableWithProtocol?) to ParentMO.

After extending the model, rake to ensure that codegen is correct, it compiles and runs.

@rtircher rtircher closed this Mar 14, 2013
@rtircher rtircher reopened this Mar 14, 2013
@rtircher
Copy link
Contributor Author

Finally got to add the tests for this.

@rentzsch
Copy link
Owner

Looks like I snuck in a fix the modified Test Dir's data model out from underneath you and now is unmergable.

Could you update your fork and reapply your model file change? That should do it. I think. You may have to temporarily replace your model file with my current model file just to get the merge to work and then reapply your model change.

@rtircher
Copy link
Contributor Author

Here you go this should do it.

@rentzsch rentzsch merged commit 72c98ed into rentzsch:master Mar 15, 2013
@rentzsch
Copy link
Owner

That does it, thanks!

@callzhang
Copy link

I am using transformable attributes. But I don't quite understand this syntax. Would you mind adding an example to this feature?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants