Grammar attempts to include non-existant 'source.regexp.python.renpy' scope

[lildude]

👋 I'm the primary GitHub maintainer for Linguist which is used for syntax highlighting on GitHub.com.

As part of this syntax highlighting, Linguist and thus GitHub.com, uses this grammar for highlighting Ren'Py files.

Our grammar validator has detected an error with this grammar:

• repository vendor/grammars/language-renpy (from https://github.com/williamd1k0/language-renpy.git) (1 errors)
  • Missing include in grammar: source.renpy (in grammars/renpy.cson) attempts to include source.regexp.python.renpy but the scope cannot be found

This is caused by:

language-renpy/source/renpy.tmpl.cson

Lines 916 to 923 in ea6e3a0

	'regular_expressions':
	'comment': 'Changed disabled to 1 to turn off syntax highlighting in “r” strings.'
	'disabled': 0
	'patterns': [
	{
	'include': 'source.regexp.python.renpy'
	}
	]

This section needs to be redefined, removed or the scope added to the grammar.

[williamd1k0]

Sorry for the delay.
This was introduced in 9ac1da3

@lildude Does changing it to source.regexp.python solve the problem?
Or I need to include a copy of regular expressions (python).cson from atom/language-python?

[lildude]

Does changing it to source.regexp.python solve the problem?

Yes as Linguist will include the file from the Python grammar that we ship.

Or I need to include a copy of regular expressions (python).cson from atom/language-python?

This would also work, but you'd need to change the scope within it to match source.regexp.python.renpy at https://github.com/atom/language-python/blob/master/grammars/regular%20expressions%20(python).cson#L2

Of the two, I'd recommend the former. That way you don't need to keep maintaining a copy and Renpy will continue to gain from the enhancements to that grammar as it evolves within the upstream grammar. I'd only recommend the latter if you plan to implement renpy-specific changes to it.

[williamd1k0]

Does changing it to source.regexp.python solve the problem?

Yes as Linguist will include the file from the Python grammar that we ship.

I believe Ren'Py won't need an alternative regex scope, so I just renamed it to source.regexp.python in c5c1777.

Thanks for helping! 👋