Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: force node 15 for lerna when npm lockfileVersion=2 #8961

Merged
merged 6 commits into from
Mar 3, 2021

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Mar 3, 2021

Changes:

Adds logic to force node 15 when npm lockfileVersion=2 and either:

  • the specified node constraint supports node@15, or
  • lerna is being used

Context:

#8553 (reply in thread)

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added unit tests, or
  • No new tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins rarkins requested a review from viceice March 3, 2021 11:55
@rarkins rarkins requested a review from viceice March 3, 2021 13:49
@rarkins rarkins enabled auto-merge (squash) March 3, 2021 13:56
@rarkins rarkins merged commit cce29e3 into master Mar 3, 2021
@rarkins rarkins deleted the feat/node-15-lerna branch March 3, 2021 14:07
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 24.72.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants