Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: yarn workspaces lock file support #743

Merged
merged 1 commit into from
Aug 27, 2017
Merged

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Aug 27, 2017

This feature adds explicit support for correctly generating the yarn.lock file for workspaces. Specifically, it means that the yarn.lock in the root directory is regenerated whenever any package.json is modified. Previously lock files were only every updated if its corresponding package.json changes, but that is not the way yarn workspaces works.

Closes #473

This feature adds explicit support for correctly generating the yarn.lock file for workspaces. Specifically, it means that the yarn.lock in the root directory is regenerated whenever *any* package.json is modified. Previously lock files were only every updated if its corresponding package.json changes, but that is not the way yarn workspaces works.

Closes #473
@codecov
Copy link

codecov bot commented Aug 27, 2017

Codecov Report

Merging #743 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #743   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          45     45           
  Lines        2697   2705    +8     
  Branches      554    557    +3     
=====================================
+ Hits         2697   2705    +8
Impacted Files Coverage Δ
lib/workers/package-file/index.js 100% <ø> (ø) ⬆️
lib/workers/branch/lock-files.js 100% <100%> (ø) ⬆️
lib/workers/repository/apis.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d98130f...1bf1fae. Read the comment docs.

@rarkins rarkins merged commit 7c3df0b into master Aug 27, 2017
@rarkins rarkins deleted the feat/473-workspaces branch August 27, 2017 06:17
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Yarn workspaces
1 participant