Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: feat: yarn workspaces support #731

Closed
wants to merge 2 commits into from
Closed

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Aug 24, 2017

  • Set experimental workspaces flag true
  • Consider setting flag in ~/.yarnrc instead
  • All package.json files need to be written at same time and yarn install run once from root even if root package.json hasn't been updated
  • Remove workspaces warning

Closes #473

@codecov
Copy link

codecov bot commented Aug 24, 2017

Codecov Report

Merging #731 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #731   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          38     38           
  Lines        2627   2634    +7     
  Branches      547    549    +2     
=====================================
+ Hits         2627   2634    +7
Impacted Files Coverage Δ
lib/workers/branch/yarn.js 100% <100%> (ø) ⬆️
lib/workers/package-file/index.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3917fc6...5391ecd. Read the comment docs.

@rarkins
Copy link
Collaborator Author

rarkins commented Aug 26, 2017

Hopefully just a few more lines of code after #736 is merged

@rarkins rarkins closed this Aug 27, 2017
@rarkins rarkins deleted the feat/473-yarn-workspaces branch August 27, 2017 11:56
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Yarn workspaces
1 participant