Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create pr even if lock file update fails #729

Closed
wants to merge 3 commits into from

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Aug 24, 2017

Previously, branches/PRs failed if lock file generation failed and the user has no warning of this. Now, these PRs will be generated with with a failed status check linking to documentation.

Closes #600

Previously, branches/PRs failed if lock file generation failed and the user has no warning of this. Now, these PRs will be generated with with a failed status check linking to documentation.

Closes #600
@codecov
Copy link

codecov bot commented Aug 24, 2017

Codecov Report

Merging #729 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #729   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          38     38           
  Lines        2627   2644   +17     
  Branches      547    553    +6     
=====================================
+ Hits         2627   2644   +17
Impacted Files Coverage Δ
lib/workers/branch/index.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3917fc6...397e35a. Read the comment docs.

@rarkins
Copy link
Collaborator Author

rarkins commented Aug 26, 2017

Waiting on #473

@rarkins rarkins closed this Sep 3, 2017
@rarkins rarkins removed the blocked label Sep 3, 2017
@rarkins rarkins deleted the feat/600-pr-no-lockfile branch October 3, 2017 08:03
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alert user to lock file failure
1 participant