fix(instrumentation): re-add span_id and trace_id to logs - #42647
Merged
Merged
Conversation
As part of recent changes to how our logger is initialised, we accidentally broke the propagation of OpenTelemtry `span_id` and `trace_id` into the Bunyan log context. We already registered `BunyanInstrumentation`, but because of the `import`, the instrumentation could not man-in-the-middle the import and register the instrumentation. This is slightly more complex, and brittle, test, but does capture the current behaviour of `BunyanInstrumentation`, if it were removed. Co-authored-by: Claude Sonnet 4.6 <jamie.tanna+claude-code@mend.io>
secustor
approved these changes
Apr 15, 2026
secustor
approved these changes
Apr 15, 2026
Contributor
|
🎉 This PR is included in version 43.123.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
viceice
reviewed
Apr 17, 2026
Comment on lines
+10
to
+12
| const bunyan = createRequire(import.meta.url)( | ||
| 'bunyan', | ||
| ) as typeof import('bunyan'); |
Member
There was a problem hiding this comment.
we should refactor to use our expost.ts (like we do with prettier and re2). will send a pr later
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
As part of recent changes to how our logger is initialised, we
accidentally broke the propagation of OpenTelemtry
span_idandtrace_idinto the Bunyan log context.We already registered
BunyanInstrumentation, but because of theimport, the instrumentation could not man-in-the-middle the import andregister the instrumentation.
This is slightly more complex, and brittle, test, but does capture the
current behaviour of
BunyanInstrumentation, if it were removed.Context
Please select one of the following:
trace_idandspan_idto logs #41847AI assistance disclosure
Did you use AI tools to create any part of this pull request?
Please select one option and, if yes, briefly describe how AI was used (e.g., code, tests, docs) and which tool(s) you used.
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via:
The public repository: