Skip to content

fix(instrumentation): ensure instrumentation is initialised first - #42471

Merged
jamietanna merged 2 commits into
mainfrom
fix/otel
Apr 8, 2026
Merged

fix(instrumentation): ensure instrumentation is initialised first#42471
jamietanna merged 2 commits into
mainfrom
fix/otel

Conversation

@viceice

@viceice viceice commented Apr 8, 2026

Copy link
Copy Markdown
Member

Changes

Context

Please select one of the following:

  • This closes an existing Issue, Closes: #
  • This doesn't close an Issue, but I accept the risk that this PR may be closed if maintainers disagree with its opening or implementation

AI assistance disclosure

Did you use AI tools to create any part of this pull request?

Please select one option and, if yes, briefly describe how AI was used (e.g., code, tests, docs) and which tool(s) you used.

  • No — I did not use AI for this contribution.
  • Yes — minimal assistance (e.g., IDE autocomplete, small code completions, grammar fixes).
  • Yes — substantive assistance (AI-generated non‑trivial portions of code, tests, or documentation).
  • Yes — other (please describe):

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests, but ran on a real repository, or
  • Both unit tests + ran on a real repository

The public repository:

@viceice
viceice requested a review from jamietanna April 8, 2026 13:44
@viceice viceice linked an issue Apr 8, 2026 that may be closed by this pull request
@jamietanna jamietanna changed the title fix(otel): instrumentation needs to done first fix(instrumentation): ensure instrumentation is initialised first Apr 8, 2026
Comment thread lib/renovate.ts Outdated
Comment thread lib/renovate.ts Outdated
Co-authored-by: Jamie Tanna <github@jamietanna.co.uk>

@jamietanna jamietanna left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running locally, I can now see HTTP spans 👍

@jamietanna
jamietanna enabled auto-merge April 8, 2026 13:48
@jamietanna
jamietanna added this pull request to the merge queue Apr 8, 2026
Merged via the queue into main with commit 83b8955 Apr 8, 2026
44 checks passed
@jamietanna
jamietanna deleted the fix/otel branch April 8, 2026 13:55
@github-actions

github-actions Bot commented Apr 8, 2026

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 43.110.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

szeidler pushed a commit to szeidler/renovate that referenced this pull request Apr 14, 2026
…novatebot#42471)

* fix(otel): instrumentation needs to done first

* Apply suggestions from code review

Co-authored-by: Jamie Tanna <github@jamietanna.co.uk>

---------

Co-authored-by: Jamie Tanna <github@jamietanna.co.uk>
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators May 9, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OpenTelemetry instrumentation does not fully instrument since 43.93.0

2 participants