fix(manager/kustomize): prevent setting replaceString for OCI chart extraction with registry aliases - #39346
Conversation
f37c22b to
b4f57ce
Compare
|
I had to force push to correct the author information of the commit. This change only addresses the issue in the It appears the specifyReplaceString parameter is being ignored in that logic. I was hesitant to make the change there as I wasn't completely sure about potential side effects for other managers. What are your thoughts? If you agree the dockerfile manager is the better approach, I'm happy to update this PR. |
|
I get the issue, but this does not seems to be the correct solution. Can you please create a minimal reproduction so we can discuss the best solution? |
|
Thanks for your fast reply! I created a minimal reproduction here: https://github.com/tiagodcc/kustomize-oci-helm |
|
🎉 This PR is included in version 42.14.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Changes
When using the kustomize manager, Helm charts may be referenced using OCI registries. However, if registry aliases are used,
replaceStringis set by thedockerfilemanager, leading to a failure while replacing the version key of the existing context. In this PR, the object keyreplaceStringis deleted using a destruction.The issue has already been described in the following discussion: #37638
Context
Please select one of the following:
AI assistance disclosure
Did you use AI tools to create any part of this pull request?
Please select one option and, if yes, briefly describe how AI was used (e.g., code, tests, docs) and which tool(s) you used.
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via:
The public repository: