Skip to content

chore(instrumentation): add helpers for Git instrumentation - #38582

Merged
jamietanna merged 1 commit into
mainfrom
chore/git-instrument
Dec 1, 2025
Merged

jamietanna merged 1 commit into
mainfrom
chore/git-instrument

Conversation

@jamietanna

@jamietanna jamietanna commented Oct 13, 2025 •

Copy link
Copy Markdown
Contributor

Changes

As part of being able to fully instrument our Git operations - using
SimpleGit - we can introduce some Git-specific instrumentation helpers.

These helpers will be used as part of a future change, where we will
instrument methods of SimpleGit that we're using.

This provides a set of types which will be used as OpenTelemetry
Attributes to categorise command types.

A number of subcommands that aren't currently deemed to be too important
are bucketed into an other category.


Note that it's worth reviewing this with the integration (#39591) in mind)

Context

Please select one of the below:

  • This closes an existing Issue: #
  • This doesn't close an Issue, but I accept the risk that this PR may be closed if maintainers disagree with its opening or implementation

AI assistance disclosure

Did you use AI tools to create any part of this pull request?

Please select one option and, if yes, briefly describe how AI was used (e.g., code, tests, docs) and which tool(s) you used.

  • No — I did not use AI for this contribution.
  • Yes — minimal assistance (e.g., IDE autocomplete, small code completions, grammar fixes).
  • Yes — substantive assistance (AI generated non‑trivial portions of code, tests, or documentation).
  • Yes — other (please describe):

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

The public repository:

@jamietanna jamietanna added this to the v42 milestone Oct 20, 2025
@jamietanna jamietanna removed this from the v42 milestone Oct 31, 2025
Comment thread lib/util/git/instrument.ts Outdated
@jamietanna
jamietanna force-pushed the chore/git-instrument branch 2 times, most recently from 1dee2ce to 3a16088 Compare November 27, 2025 14:36
Comment thread lib/util/git/instrument.ts Outdated
Comment thread lib/util/git/instrument.ts Outdated
Comment thread lib/util/git/instrument.ts Outdated
@jamietanna jamietanna changed the title chore(git): add basis of tracing chore(instrumentation): add Git instrumentation interface Nov 28, 2025
@jamietanna
jamietanna changed the base branch from main to chore/span-split November 28, 2025 11:59
@jamietanna
jamietanna force-pushed the chore/span-split branch 3 times, most recently from a5104fe to 29c168d Compare November 28, 2025 12:24
Comment thread lib/instrumentation/types.ts Outdated
Base automatically changed from chore/span-split to main November 28, 2025 12:37
@jamietanna
jamietanna force-pushed the chore/git-instrument branch 3 times, most recently from 521521c to 893821b Compare November 28, 2025 14:27
Comment thread lib/util/git/types.ts
@jamietanna
jamietanna force-pushed the chore/git-instrument branch 2 times, most recently from ec20ae9 to 4d6800c Compare November 28, 2025 16:09
As part of being able to fully instrument our Git operations - using
SimpleGit - we can introduce some Git-specific instrumentation helpers.

These helpers will be used as part of a future change, where we will
instrument methods of SimpleGit that we're using.

This provides a set of types which will be used as OpenTelemetry
Attributes to categorise command types.

A number of subcommands that aren't currently deemed to be too important
are bucketed into an `other` category.
@jamietanna jamietanna changed the title chore(instrumentation): add Git instrumentation interface chore(instrumentation): add helpers for Git instrumentation Nov 28, 2025
@jamietanna
jamietanna marked this pull request as ready for review November 28, 2025 17:17
@jamietanna
jamietanna added this pull request to the merge queue Dec 1, 2025
Merged via the queue into main with commit fe8fe42 Dec 1, 2025
43 of 60 checks passed
@jamietanna
jamietanna deleted the chore/git-instrument branch December 1, 2025 09:57
@github-actions

github-actions Bot commented Dec 1, 2025

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 42.27.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jan 1, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants