Skip to content

feat(config): baseBranchPatterns#35579

Merged
rarkins merged 11 commits intorenovatebot:mainfrom
RahulGautamSingh:feat/base-branch-patterns
Jul 14, 2025
Merged

feat(config): baseBranchPatterns#35579
rarkins merged 11 commits intorenovatebot:mainfrom
RahulGautamSingh:feat/base-branch-patterns

Conversation

@RahulGautamSingh
Copy link
Collaborator

Changes

  • Replace baseBranches -> baseBranchPatterns

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@RahulGautamSingh RahulGautamSingh force-pushed the feat/base-branch-patterns branch from 16b43cd to a12cda1 Compare April 27, 2025 08:29
@RahulGautamSingh RahulGautamSingh requested review from rarkins and removed request for rarkins April 27, 2025 08:37
Copy link
Contributor

@rarkins rarkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Docs should mention that it was formerly known as baseBranches
  2. Needs global config migration too just in case (CLI, env)

@RahulGautamSingh
Copy link
Collaborator Author

Needs global config migration too just in case (CLI, env)

cli is false for this option

@rarkins
Copy link
Contributor

rarkins commented May 1, 2025

@RahulGautamSingh this is what Codecov is complaining about:

image

@RahulGautamSingh RahulGautamSingh requested a review from viceice May 1, 2025 15:36
secustor
secustor previously approved these changes May 4, 2025
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just s small thing

Copy link
Contributor

@rarkins rarkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How extensively tested is this on real repos?

@RahulGautamSingh
Copy link
Collaborator Author

@RahulGautamSingh RahulGautamSingh requested a review from rarkins May 15, 2025 03:44
secustor
secustor previously approved these changes May 15, 2025
viceice
viceice previously approved these changes May 27, 2025
@viceice
Copy link
Member

viceice commented Jun 6, 2025

@rarkins needs your approval

@RahulGautamSingh
Copy link
Collaborator Author

Needs attention :)

@RahulGautamSingh RahulGautamSingh requested a review from rarkins July 12, 2025 16:32
@rarkins rarkins enabled auto-merge July 14, 2025 19:05
@rarkins rarkins added this pull request to the merge queue Jul 14, 2025
Merged via the queue into renovatebot:main with commit 3691ff9 Jul 14, 2025
40 checks passed
@renovate-release
Copy link

🎉 This PR is included in version 41.34.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

snazy added a commit to snazy/polaris that referenced this pull request Jul 15, 2025
Looks that I accidentally broke Renovate with apache#1891. This was made under the impression of the [Renovate change to support `baseBranches` in forking-renovate] (renovatebot/renovate#36054). However, a [later Renovate change](renovatebot/renovate#35579)  seems to break that.

The plan here is to:
1. remove the regex from our `baseBranches` option - if that doesn't work then
2. just use the default branch
jbonofre pushed a commit to apache/polaris that referenced this pull request Jul 15, 2025
Looks that I accidentally broke Renovate with #1891. This was made under the impression of the [Renovate change to support `baseBranches` in forking-renovate] (renovatebot/renovate#36054). However, a [later Renovate change](renovatebot/renovate#35579)  seems to break that.

The plan here is to:
1. remove the regex from our `baseBranches` option - if that doesn't work then
2. just use the default branch
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants