fix(nix): urldecode gitlab subgroups#34863
Merged
rarkins merged 1 commit intorenovatebot:mainfrom Mar 17, 2025
Merged
Conversation
Do to a bug in nix one needs to uri encode the owner of a gitlab repository that resides in a subgroups, in this case the `/` as `%20F`. This however breaks the `git ls-remotes` which renovate runs to discover if the input can be updated. This commit passes the owner attribute through `decodeURIComponent` to ensure that `git` is unware of this workaround on nixs side. Nix PR: NixOS/nix#9163
xanderio
force-pushed
the
fix-nix-gitlab
branch
from
2b50fe1 to
548d780
Compare
rarkins
approved these changes
Mar 17, 2025
|
🎉 This PR is included in version 39.207.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
viceice
reviewed
Mar 18, 2025
| }); | ||
| }); | ||
|
|
||
| const flake12Lock = `{ |
Member
There was a problem hiding this comment.
should be moved inside the test and use codeBlock template helper
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do to a bug in nix one needs to uri encode the owner of a gitlab repository that resides in a subgroups, in this case the
/as%20F. This however breaks thegit ls-remoteswhich renovate runs to discover if the input can be updated.This commit passes the owner attribute through
decodeURIComponentto ensure thatgitis unware of this workaround on nixs side.Nix PR: NixOS/nix#9163
Changes
Context
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: