fix(lockfilemaintenance): ensure isLockFileMaintenance on grouping

[viceice]

Changes

ensure isLockFileMaintenance is true if grouping lockefile maintenance with other updates even it's not really supported.

Context

• closes fix(composer): resolve the lockFileMaintenance not working #32384

Documentation (please check one with an [x])

• I have updated the documentation, or
• No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

• Code inspection only, or
• Newly added/modified unit tests, or
• No unit tests but ran on a real repository, or
• Both unit tests + ran on a real repository

[rarkins]

When I see old code which references config.updateType, it implies to me that config just be an "update" config and not a "branch" config.

[viceice]

no. it's the branch config, so it simply assumes the proper update type was copied to branch config

[rarkins]

Here, config = branch config. So you're setting branchConfig.isLockFileMaintenance=true if any update in the branch has isLockFileMaintenance set. This seems logically correct. But I think updateArtifacts() is no called on a full branch, so the refactorings within manager code seem unrelated or mismatched with this change?

[viceice]

No, it's passing the full branch config. patchConfigForArtifactsUpdate is only patching the lockFiles property and config is of BranchConfig type.

renovate/lib/workers/repository/update/branch/get-updated.ts

Lines 334 to 344 in f182708

	const results = await managerUpdateArtifacts(manager, {
	packageFileName: packageFile.path,
	updatedDeps,
	// TODO #22198
	newPackageFileContent: packageFile.contents!.toString(),
	config: patchConfigForArtifactsUpdate(
	config,
	manager,
	packageFile.path,
	),
	});

renovate/lib/workers/repository/update/branch/get-updated.ts

Lines 375 to 385 in f182708

	const results = await managerUpdateArtifacts(manager, {
	packageFileName: packageFile.path,
	updatedDeps,
	// TODO #22198
	newPackageFileContent: packageFile.contents!.toString(),
	config: patchConfigForArtifactsUpdate(
	config,
	manager,
	packageFile.path,
	),
	});

renovate/lib/workers/repository/update/branch/get-updated.ts

Lines 421 to 429 in f182708

	packageFileName: packageFile.path,
	updatedDeps: [],
	newPackageFileContent: contents!,
	config: patchConfigForArtifactsUpdate(
	config,
	manager,
	packageFile.path,
	),
	});

[secustor]

I would test this at least once on a real repo.

[viceice]

I would test this at least once on a real repo.

ok, it only occurs when grouping lock file maintenance with other updates, so will search the discussions for a repro repo