-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(config/migration): migrate package.json config #33633
base: main
Are you sure you want to change the base?
feat(config/migration): migrate package.json config #33633
Conversation
]; | ||
|
||
if (pJsonMigration) { | ||
const pJson = JSON.parse((await readLocalFile('package.json', 'utf8'))!); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use our json utils
const pJsonContent = await applyPrettierFormatting( | ||
'package.json', | ||
JSON.stringify(pJson, undefined, migratedConfigData.indent.indent), | ||
upath.extname('package.json').replace('.', '') as PrettierParser, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
upath.extname('package.json').replace('.', '') as PrettierParser, | |
'json', |
simplify?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM outside of existing comments
const pJson = parseJson( | ||
await readLocalFile('package.json', 'utf8'), | ||
'package.json', | ||
) as any; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
) as any; | |
) as unknown; |
Don't use any
Changes
package.json
file by deleting the config from thepackage.json
file and creating a newrenovate.json
file with the migrated config.Context
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: