Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(preset): adding Azure and AzureAD monorepos (SDK and auth) #33624

Merged
merged 4 commits into from
Jan 24, 2025

Conversation

klippx
Copy link
Contributor

@klippx klippx commented Jan 15, 2025

Changes

Added a couple of known monorepos related to Azure and AzureAD

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@klippx klippx force-pushed the monorepos/azure branch 2 times, most recently from ec0cef7 to 929a5ed Compare January 15, 2025 10:58
lib/data/monorepo.json Outdated Show resolved Hide resolved
@klippx
Copy link
Contributor Author

klippx commented Jan 15, 2025

@rarkins Should I add new entries to orgGroups ?

  "orgGroups": {
    ...
    "azure": "https://github.com/Azure/",
    "azure-ad": "https://github.com/AzureAD/",
    ...
  }

I notice there are relatively few entries there, not sure what it is used for, interested to learn.

@rarkins
Copy link
Collaborator

rarkins commented Jan 20, 2025

@rarkins Should I add new entries to orgGroups ?

  "orgGroups": {
    ...
    "azure": "https://github.com/Azure/",
    "azure-ad": "https://github.com/AzureAD/",
    ...
  }

Only if every single package published within those orgs should be upgraded together, which sounds unlikely to me

lib/data/monorepo.json Outdated Show resolved Hide resolved
lib/data/monorepo.json Outdated Show resolved Hide resolved
lib/data/monorepo.json Outdated Show resolved Hide resolved
@viceice viceice added the breaking Breaking change, requires major version bump label Jan 20, 2025
@klippx klippx requested review from viceice and rarkins January 20, 2025 10:33
@klippx
Copy link
Contributor Author

klippx commented Jan 20, 2025

@viceice No longer breaking; I want a smooth merge experience

@viceice viceice added this pull request to the merge queue Jan 24, 2025
Merged via the queue into renovatebot:main with commit e08de87 Jan 24, 2025
39 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 39.130.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking change, requires major version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants