-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(bazel-module): support bazel_dep
dependencies without the version
parameter
#33496
Merged
rarkins
merged 7 commits into
renovatebot:main
from
reutermj:feat/support-bazel_dep-no-version
Jan 30, 2025
Merged
feat(bazel-module): support bazel_dep
dependencies without the version
parameter
#33496
rarkins
merged 7 commits into
renovatebot:main
from
reutermj:feat/support-bazel_dep-no-version
Jan 30, 2025
+375
−120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reutermj
force-pushed
the
feat/support-bazel_dep-no-version
branch
from
January 18, 2025 20:25
983d9e8
to
c5bc9ff
Compare
@rarkins Sorry about the ping, not seeing in the UI how to request a review for this |
Yeah I tried following that page, but the github UI I see does not include suggested reviewers or the ability to select a reviewer |
rarkins
requested changes
Jan 27, 2025
viceice
reviewed
Jan 27, 2025
Co-authored-by: Rhys Arkins <[email protected]> Co-authored-by: Michael Kriese <[email protected]>
auto-merge was automatically disabled
January 28, 2025 15:48
Head branch was pushed to by a user without write access
viceice
approved these changes
Jan 30, 2025
rarkins
approved these changes
Jan 30, 2025
🎉 This PR is included in version 39.145.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
reutermj
added a commit
to cortecs-lang/cortecs
that referenced
this pull request
Jan 31, 2025
Renovate has been improved to remove the limitation that required a no-op version on overridden `bazel_dep` dependencies. renovatebot/renovate#33496
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This adds support for
bazel_dep
dependencies without theversion
parameter declared inMODULE.bazel
files.Context
MODULE.bazel
files allow forbazel_dep
dependencies to be declared without theversion
parameter. This is used in conjunction with overrides such asgit_override
,single_version_override
, orlocal_path_override
to provide the dependency version. Currently, renovate does not recognize overridden dependencies without theversion
parameter on thebazel_dep
, and it requires a no-op version to be added to thebazel_dep
to recognize the override and correctly update the override version.Before:
After:
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: