Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bazel-module): support bazel_dep dependencies without the version parameter #33496

Merged
merged 7 commits into from
Jan 30, 2025

Conversation

reutermj
Copy link
Contributor

@reutermj reutermj commented Jan 9, 2025

Changes

This adds support for bazel_dep dependencies without the version parameter declared in MODULE.bazel files.

Context

MODULE.bazel files allow for bazel_dep dependencies to be declared without the version parameter. This is used in conjunction with overrides such as git_override, single_version_override, or local_path_override to provide the dependency version. Currently, renovate does not recognize overridden dependencies without the version parameter on the bazel_dep, and it requires a no-op version to be added to the bazel_dep to recognize the override and correctly update the override version.

Before:

# the MODULE.bazel in flecs does not declare a version parameter, but this is required for renovate
bazel_dep(name = "flecs", version = "0.0.0") 
git_override(
    module_name = "flecs",
    remote = "https://github.com/SanderMertens/flecs.git",
    commit = "8a1e9abe412eda7cd7f2a7440dac7499ce42cdca",
)

After:

bazel_dep(name = "flecs") 
git_override(
    module_name = "flecs",
    remote = "https://github.com/SanderMertens/flecs.git",
    commit = "8a1e9abe412eda7cd7f2a7440dac7499ce42cdca",
)

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@reutermj reutermj force-pushed the feat/support-bazel_dep-no-version branch from 983d9e8 to c5bc9ff Compare January 18, 2025 20:25
@reutermj
Copy link
Contributor Author

@rarkins Sorry about the ping, not seeing in the UI how to request a review for this

@reutermj
Copy link
Contributor Author

Yeah I tried following that page, but the github UI I see does not include suggested reviewers or the ability to select a reviewer

@rarkins rarkins self-requested a review January 22, 2025 15:51
docs/usage/bazel.md Outdated Show resolved Hide resolved
lib/modules/manager/bazel-module/extract.spec.ts Outdated Show resolved Hide resolved
lib/modules/manager/bazel-module/extract.spec.ts Outdated Show resolved Hide resolved
lib/modules/manager/bazel-module/extract.spec.ts Outdated Show resolved Hide resolved
lib/modules/manager/bazel-module/extract.spec.ts Outdated Show resolved Hide resolved
lib/modules/manager/bazel-module/extract.spec.ts Outdated Show resolved Hide resolved
lib/modules/manager/bazel-module/rules.ts Outdated Show resolved Hide resolved
@rarkins rarkins enabled auto-merge January 27, 2025 19:10
Co-authored-by: Rhys Arkins <[email protected]>
Co-authored-by: Michael Kriese <[email protected]>
auto-merge was automatically disabled January 28, 2025 15:48

Head branch was pushed to by a user without write access

@reutermj reutermj requested review from viceice and rarkins January 29, 2025 15:29
@rarkins rarkins enabled auto-merge January 30, 2025 12:11
@rarkins rarkins added this pull request to the merge queue Jan 30, 2025
Merged via the queue into renovatebot:main with commit 4ca76e4 Jan 30, 2025
39 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 39.145.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

reutermj added a commit to cortecs-lang/cortecs that referenced this pull request Jan 31, 2025
Renovate has been improved to remove the limitation that required a no-op version on overridden `bazel_dep` dependencies.
renovatebot/renovate#33496
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants