feat(submodules): use env vars from getGitEnvironmentVariables #31934
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This change uses the existing
getGitEnvironmentVariables
function during the cloning of git submodules.This function has been used to include support for updating private git ssh submodules on github.com, but it was not added in the function triggered when the
cloneSubmodules
config file option is set to true.see: #22061
Context
#30942
Private submodules on the github.com app cannot currently be cloned with the
cloneSubmodules
option when the.gitmodules
file is configured with ssh.This is because the GitHub App token does not have SSH permissions, it can only auth via HTTP.
My use case is private Go submodules on github.com, for the
"postUpdateOptions": ["gomodTidy", "gomodUpdateImportPaths"],
options to work, I need my private git submodules cloned.Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: