fix(manager/uv): skip unsupported sources #31270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkniewallner
force-pushed
the
fix/skip-non-pypi-dependencies-uv
branch
2 times, most recently
from
591bcb0 to
7183564
Compare
mkniewallner
changed the title
mkniewallner
force-pushed
the
fix/skip-non-pypi-dependencies-uv
branch
from
7183564 to
0eba47d
Compare
mkniewallner
commented
Sep 8, 2024
6 tasks
rarkins
reviewed
Sep 9, 2024
rarkins
requested changes
Sep 9, 2024
rarkins
previously approved these changes
Sep 9, 2024
viceice
reviewed
Sep 9, 2024
6 tasks
…-non-pypi-dependencies-uv
viceice
approved these changes
Sep 9, 2024
secustor
reviewed
Sep 9, 2024
|
🎉 This PR is included in version 38.73.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
6 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Skip dependencies that define a source that is not yet supported by Renovate.
Context
This emerges from discussion in #31186 (comment). This will avoid having Renovate try to search for dependencies in PyPI if the dependencies are actually mapped to other sources (like a git repository, or a local path).
The end result is really similar to what is done in Cargo, and is defensive against potential new sources that could be added.
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: