fix(datasource/repology): throw if package/repo not found

[kayman-mk]

Changes

This PR adds a warning to the log file if the Repology datasource is not able to find the package and/or repository. It was a debug message before.

Context

In case package/repository are not found it needs to visible in the daily work with Renovate as these packages are never updated due to a wrong setup by the user. Usually the logs are set to info or even warn as you don't wan't to see debug messages on a regular basis.

Documentation (please check one with an [x])

• I have updated the documentation, or
• No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

• Code inspection only, or
• Newly added/modified unit tests, or
• No unit tests but ran on a real repository, or
• Both unit tests + ran on a real repository

[rarkins]

Suggested change

	throw new Error(`Repository or package not found on Repology: ${repoName}/${pkgName}`);
	throw err;

[kayman-mk]

But this does not work as there is no err.

TS2304: Cannot find name err

[rarkins]

How is this code reached and for what reasons?

[rarkins]

I looked and there's very few manually thrown errors in datasources. Ideally we shouldn't invent a new type of error here

[kayman-mk]

Before there was a logger.debug which I changed to logger.warn to make the problem visible in the logs. See above. May be switch back to the first solution?

[github-actions]

Please create a GitHub Discussion before continuing with this PR.

Thank you for your PR, but we need to discuss the requirements and implementation first.

The maintainers believe that there is a lack of - or misalignment of - requirements about this PR. We need to discuss the requirements and implementation first so that you don't write code that won't be merged.

This PR will be closed for now to avoid confusion, but you can reopen it after the discussion has been resolved.

Thanks, the Renovate team

[rarkins]

Sorry, let's have a discussion about this first, because I don't think this is an obvious change or repology-specific.

null is a valid result, Repology probably isn't the only datasource which can return it and shouldn't have unique handling of it

renovate/lib/modules/datasource/datasource.ts

Lines 37 to 39 in a35197c

	abstract getReleases(
	getReleasesConfig: GetReleasesConfig,
	): Promise<ReleaseResult | null>;