refactor(cache): Deprecate namespace parameter in decorators #31079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
zharinov
changed the title
zharinov
changed the title
viceice
reviewed
Sep 3, 2024
| function getClassName(instance: unknown): string | undefined { | ||
| // istanbul ignore if: should never happen | ||
| if (!is.object(instance)) { | ||
| return undefined; |
There was a problem hiding this comment.
we should throw if it's happening. undefined is a bad namespace.
or at least log a stack trace at debug level to see how it happens.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR deprecates usage of cache namespace for decorators, using the default one (equals the class name).
We could then remove
namespaceparamter per-datasource. Since the default namespace is different, it leads to cache reset.The alternative is to apply class name transformation, e.g.
FooBarDatasourcetodatasource-foo-bar, but maybe it's easier to just gradually move to new namespaces.Context
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: