Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(gitlab-tags): Use single cache namespace #31038

Merged
merged 3 commits into from
Aug 27, 2024
+6 −7
Merged

refactor(gitlab-tags): Use single cache namespace #31038

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cd8dc3d
refactor(gitlab-tags): Use single cache namespace
zharinov Aug 26, 2024
af9d201
Merge branch 'main' into refactor/gitlab-tags-cache-namespace
zharinov Aug 27, 2024
19792e1
Fix types
zharinov Aug 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/modules/datasource/gitlab-tags/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ export class GitlabTagsDatasource extends Datasource {
@cache({
namespace: `datasource-${GitlabTagsDatasource.id}`,
key: ({ registryUrl, packageName }: GetReleasesConfig) =>
`${getDepHost(registryUrl)}:${packageName}`,
`getReleases:${getDepHost(registryUrl)}:${packageName}`,
})
async getReleases({
registryUrl,
Expand Down Expand Up @@ -72,9 +72,9 @@ export class GitlabTagsDatasource extends Datasource {
* Returs the latest commit hash of the repository.
*/
@cache({
namespace: `datasource-${GitlabTagsDatasource.id}-commit`,
namespace: `datasource-${GitlabTagsDatasource.id}`,
key: ({ registryUrl, packageName }: GetReleasesConfig) =>
viceice marked this conversation as resolved.
Show resolved Hide resolved
`${getDepHost(registryUrl)}:${packageName}`,
`getDigest:${getDepHost(registryUrl)}:${packageName}`,
})
override async getDigest(
{ packageName: repo, registryUrl }: Partial<DigestConfig>,
Expand Down
1 change: 0 additions & 1 deletion lib/util/cache/package/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,6 @@ export type PackageCacheNamespace =
| 'datasource-github-release-attachments'
| 'datasource-gitlab-packages'
| 'datasource-gitlab-releases'
| 'datasource-gitlab-tags-commit'
| 'datasource-gitlab-tags'
| 'datasource-glasskube-packages'
| 'datasource-go-direct'
Expand Down