Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(docker): Use single namespace for cache #31035

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

zharinov
Copy link
Collaborator

Changes

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this changes a lot namespaces, so it has a big impact on the hosted app

@rarkins
Copy link
Collaborator

rarkins commented Aug 27, 2024

Let's try to get them all some soon after one another

@zharinov
Copy link
Collaborator Author

Long-term incremental cache of the packages is intact, so shouldn't be a big problem

@rarkins rarkins requested a review from viceice August 28, 2024 05:24
@@ -42,14 +42,8 @@ export type PackageCacheNamespace =
| 'datasource-crate-metadata'
| 'datasource-crate'
| 'datasource-deno'
| 'datasource-docker-architecture'
| 'datasource-docker'
| 'datasource-docker-hub-cache'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this remaining? 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants