fix(manager/git-submodules): get recorded submodule commit #30976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rarkins
approved these changes
Aug 23, 2024
|
🎉 This issue has been resolved in version 38.51.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
oxdev03
pushed a commit
to oxdev03/renovate
that referenced
this pull request
Aug 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Get submodule state recorded in git commit, not the state of the current working copy.
Context
https://github.com/amezin/renovate-submodule-fail
When
persistRepoDatais enabled, Renovate updates the submodule(s), and leaves the repository in that state. Next timecurrentDigestfor the submodule(s) is detected incorrectly (because they are already updated in the working copy), so no update is detected, and pull requests are closed.Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: