Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(contributing): improve instructions for batch applying review suggestions #30829

Conversation

HonkingGoose
Copy link
Collaborator

Changes

  • You can "commit as often as you want", but we still want you to batch apply review suggestions
  • Small rewrite of the section about applying review suggestions

Context

A new contributor read "commit as often" to also mean one commit per review suggestion:

So I'm improving the instructions in the docs. 😄

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@HonkingGoose HonkingGoose changed the title docs(contributing): improve instructions for batch apply review suggestions docs(contributing): improve instructions for batch applying review suggestions Aug 16, 2024
@rarkins rarkins added this pull request to the merge queue Aug 18, 2024
Merged via the queue into renovatebot:main with commit 14cb0ec Aug 18, 2024
38 checks passed
@renovate-release
Copy link
Collaborator

🎉 This issue has been resolved in version 38.40.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@HonkingGoose HonkingGoose deleted the docs/30799-better-batch-apply-instructions branch August 20, 2024 09:12
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants