Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(manager/gleam): add lockfile support #30811

Closed
wants to merge 11 commits into from
Closed

feat(manager/gleam): add lockfile support #30811

wants to merge 11 commits into from

Conversation

SnakeDoc
Copy link
Contributor

@SnakeDoc SnakeDoc commented Aug 16, 2024 •
edited
Loading

Changes

Adds lock file support to the Gleam manager. Remove restrictions on "update-lockfile" rangeStrategy.

Context

The Gleam manager currently does not understand the lock file or support the "update-lockfile" rangeStrategy. It would be convenient if it did.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@SnakeDoc SnakeDoc changed the title feat: add lockfile support for gleam feat(manager/gleam): add lockfile support Aug 16, 2024
@viceice viceice self-requested a review August 16, 2024 05:54
viceice
viceice reviewed Aug 19, 2024
View reviewed changes
lib/modules/manager/gleam/extract.ts Show resolved Hide resolved
lib/modules/manager/gleam/range.ts Outdated Show resolved Hide resolved
lib/modules/manager/gleam/update-locked.ts Outdated Show resolved Hide resolved
lib/modules/manager/gleam/update-locked.ts Outdated Show resolved Hide resolved
@SnakeDoc SnakeDoc requested a review from viceice August 22, 2024 06:55
@SnakeDoc
Copy link
Contributor Author

Following the example set by Cargo, I have also added a note about Gleam manager's support for update-lockfile in 385046a

viceice
viceice reviewed Aug 22, 2024
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

normally we split those PR's to multiple for easier review:

  1. extract locked version
  2. update the updateArtifacts enable range strategies
  3. implement updateLocked if needed

lib/modules/manager/gleam/update-locked.ts Outdated Show resolved Hide resolved
lib/modules/manager/gleam/update-locked.ts Outdated Show resolved Hide resolved
lib/modules/manager/gleam/extract.ts Show resolved Hide resolved
lib/modules/manager/gleam/artifacts.ts Show resolved Hide resolved
@SnakeDoc SnakeDoc requested a review from viceice August 23, 2024 05:24
This was referenced Aug 25, 2024
Closed
Merged
@SnakeDoc
Copy link
Contributor Author

SnakeDoc commented Aug 25, 2024 •
edited
Loading

This PR has been superseded by #31000 and #31002. Closing in favor of those PR's.

@SnakeDoc SnakeDoc closed this Aug 25, 2024
@SnakeDoc SnakeDoc mentioned this pull request Aug 25, 2024
Open
6 tasks
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viceice viceice Awaiting requested review from viceice

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SnakeDoc @viceice