Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: data validation using schema #30797

Merged
merged 13 commits into from
Aug 29, 2024
Merged

refactor: data validation using schema #30797

merged 13 commits into from
Aug 29, 2024

Conversation

RahulGautamSingh
Copy link
Collaborator

Changes

  • Add zod schema for monorepo.json which will be used during linting for validation
  • Add JSON schema for monorepo.json for better user ux

Context

Ref: #29942 (comment)

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

viceice
viceice reviewed Aug 15, 2024
View reviewed changes
tools/schemas/monorepo-schema.json Outdated Show resolved Hide resolved
tools/validate-schemas.ts Outdated Show resolved Hide resolved
viceice
viceice reviewed Aug 19, 2024
View reviewed changes
lib/data/monorepo.json Outdated Show resolved Hide resolved
test/validate-schemas.spec.ts Show resolved Hide resolved
test/validate-schemas.spec.ts Show resolved Hide resolved
test/validate-schemas.spec.ts Outdated Show resolved Hide resolved
test/validate-schemas.spec.ts Outdated Show resolved Hide resolved
@HonkingGoose HonkingGoose removed their request for review August 21, 2024 09:40
@HonkingGoose
Copy link
Collaborator

I'll let the maintainers review this PR. I don't know enough to help review. 😉

viceice
viceice reviewed Aug 26, 2024
View reviewed changes
test/validate-schemas.spec.ts Outdated Show resolved Hide resolved
test/validate-schemas.spec.ts Show resolved Hide resolved
@viceice viceice added this pull request to the merge queue Aug 28, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Aug 28, 2024
@rarkins rarkins added this pull request to the merge queue Aug 29, 2024
Merged via the queue into renovatebot:main with commit d1af677 Aug 29, 2024
38 checks passed
@renovate-release
Copy link
Collaborator

🎉 This issue has been resolved in version 38.57.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viceice viceice viceice approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@RahulGautamSingh @HonkingGoose @renovate-release @viceice @rarkins