Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(docker): add ghworkflows example for GAR with Workload Identity #30692

Merged
merged 4 commits into from
Aug 24, 2024

Conversation

jazzlyn
Copy link
Contributor

@jazzlyn jazzlyn commented Aug 10, 2024

Changes

update documentation to show a proper example of docker data source configuration with GitHub workflows, workload identity and Google artifact registry.

Context

#29618 (reply in thread)

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

rarkins
rarkins previously approved these changes Aug 11, 2024
@rarkins rarkins enabled auto-merge August 11, 2024 09:45
auto-merge was automatically disabled August 11, 2024 10:07

Head branch was pushed to by a user without write access

@jazzlyn jazzlyn requested a review from rarkins August 11, 2024 10:09
Copy link
Collaborator

@HonkingGoose HonkingGoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First round of review.

docs/usage/docker.md Outdated Show resolved Hide resolved
docs/usage/docker.md Outdated Show resolved Hide resolved
docs/usage/docker.md Outdated Show resolved Hide resolved
docs/usage/docker.md Outdated Show resolved Hide resolved
docs/usage/docker.md Show resolved Hide resolved
Copy link
Collaborator

@HonkingGoose HonkingGoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a list of steps is easier to read and skim than the plain sentences we have now. Also we should break up the wall of text at the bottom.

docs/usage/docker.md Outdated Show resolved Hide resolved
docs/usage/docker.md Outdated Show resolved Hide resolved
docs/usage/docker.md Outdated Show resolved Hide resolved
docs/usage/docker.md Outdated Show resolved Hide resolved
docs/usage/docker.md Outdated Show resolved Hide resolved
docs/usage/docker.md Show resolved Hide resolved
Copy link
Collaborator

@HonkingGoose HonkingGoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with the docs. We still need a maintainer to check the technical accuracy of the text though.

docs/usage/docker.md Show resolved Hide resolved
@rarkins rarkins enabled auto-merge August 24, 2024 06:37
@rarkins rarkins added this pull request to the merge queue Aug 24, 2024
Merged via the queue into renovatebot:main with commit fca6193 Aug 24, 2024
38 checks passed
@renovate-release
Copy link
Collaborator

🎉 This issue has been resolved in version 38.52.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants