feat: auto inject Bitrise default host rule #30490
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rarkins
reviewed
Jul 30, 2024
rarkins
reviewed
Jul 31, 2024
rarkins
reviewed
Jul 31, 2024
viceice
reviewed
Aug 2, 2024
secustor
commented
Aug 2, 2024
viceice
previously approved these changes
Sep 30, 2024
rarkins
reviewed
Dec 6, 2024
Comment on lines
33
to
42
| ```json title="Host Rule which matches the Bitrise step lib repository and datasource" | ||
| { | ||
| "hostRules": [ | ||
| { | ||
| "hostType": "bitrise", | ||
| "matchHost": "https://api.github.com/repos/my-org/my-repo/contents" | ||
| } | ||
| ] | ||
| } | ||
| ``` |
There was a problem hiding this comment.
I don't like having a host rule in docs which "does nothing". Would adding a dummy token here be appropriate?
viceice
previously approved these changes
Dec 12, 2024
|
What do you expect to break / cause harm? 🤔 The token is scoped to the repository. |
I'm not sure. it's a feeling. |
|
@secustor Why was this closed? Is it not getting merged? |
|
I have accidentally deleted the branch, while cleaning up my fork. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Injects new hostRules scoped to the
bitrisehostType and matchHosthttps://api.github.com/repos/bitrise-io/bitrise-steplib/contents.Context
Currently, by default no authorization header are added while looking up Bitrise data, which results in rate limiting for bigger runs.
This is an alternative to setting the hostType to
github.Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: