Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build!: require node v20 #30291

Merged
merged 2 commits into from
Jul 22, 2024
Merged

build!: require node v20 #30291

merged 2 commits into from
Jul 22, 2024

Conversation

viceice
Copy link
Member

@viceice viceice commented Jul 22, 2024 •
edited
Loading

Changes

Require node v20 (with latest security fixes)

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@viceice viceice added the breaking Breaking change, requires major version bump label Jul 22, 2024
@viceice viceice requested review from rarkins and secustor July 22, 2024 08:56
@viceice viceice mentioned this pull request Jul 22, 2024
Closed
23 tasks
rarkins
rarkins requested changes Jul 22, 2024
View reviewed changes
docs/development/local-development.md Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@viceice viceice requested a review from rarkins July 22, 2024 09:50
@viceice viceice merged commit f8d82e7 into v38 Jul 22, 2024
34 checks passed
@viceice viceice deleted the feat/node-v20 branch July 22, 2024 10:05
rarkins pushed a commit that referenced this pull request Jul 23, 2024
@viceice @rarkins
build!: require node v20 (#30291)
82b75c6
rarkins pushed a commit that referenced this pull request Jul 23, 2024
@viceice @rarkins
build!: require node v20 (#30291)
ee6c5b6
viceice added a commit that referenced this pull request Jul 23, 2024
@viceice
build!: require node v20 (#30291)
d66408f
viceice added a commit that referenced this pull request Jul 24, 2024
@viceice
build!: require node v20 (#30291)
ac9131f
rarkins pushed a commit that referenced this pull request Jul 25, 2024
@viceice @rarkins
build!: require node v20 (#30291)
8cfd9e5
rarkins pushed a commit that referenced this pull request Jul 25, 2024
@viceice @rarkins
build!: require node v20 (#30291)
764b40c
rarkins pushed a commit that referenced this pull request Jul 25, 2024
@viceice @rarkins
build!: require node v20 (#30291)
09824b1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pandapsy Pandapsy Pandapsy left review comments

@rarkins rarkins rarkins approved these changes

@secustor secustor secustor approved these changes

@SamyDgz SamyDgz SamyDgz approved these changes

Assignees
No one assigned
Labels
breaking Breaking change, requires major version bump
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@viceice @rarkins @secustor @Pandapsy @SamyDgz