Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(lib/data): monorepo #30210

Merged
merged 23 commits into from
Jul 19, 2024
Merged

refactor(lib/data): monorepo #30210

merged 23 commits into from
Jul 19, 2024

Conversation

RahulGautamSingh
Copy link
Collaborator

@RahulGautamSingh RahulGautamSingh commented Jul 17, 2024 •
edited

Changes

  • move preset objects from monorepo.ts to lib/data/monorepo.json
  • add lib/data/readme

Context

Part of: #29942

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

@RahulGautamSingh RahulGautamSingh marked this pull request as draft July 17, 2024 08:52
HonkingGoose
HonkingGoose suggested changes Jul 17, 2024
View reviewed changes
lib/data/readme.md Show resolved Hide resolved
@RahulGautamSingh
modify group presets logic
40a1288 
necessary as monorepo presets are used
@RahulGautamSingh RahulGautamSingh marked this pull request as ready for review July 17, 2024 10:38
viceice
viceice reviewed Jul 17, 2024
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should create a JSON Schema for it, so it's helping users with tools like vscode

lib/config/presets/internal/monorepos.ts Outdated Show resolved Hide resolved
@RahulGautamSingh RahulGautamSingh marked this pull request as draft July 17, 2024 12:16
@RahulGautamSingh RahulGautamSingh changed the title refactor(lib/data): monorepo refactor(lib/data): monorepo [wip] Jul 17, 2024
@RahulGautamSingh RahulGautamSingh marked this pull request as ready for review July 17, 2024 13:12
viceice
viceice requested changes Jul 17, 2024
View reviewed changes
lib/util/http/index.ts Outdated Show resolved Hide resolved
lib/workers/global/config/parse/cli.ts Outdated Show resolved Hide resolved
lib/workers/global/index.ts Outdated Show resolved Hide resolved
viceice
viceice reviewed Jul 17, 2024
View reviewed changes
tsconfig.app.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@RahulGautamSingh RahulGautamSingh marked this pull request as draft July 17, 2024 15:23
@RahulGautamSingh RahulGautamSingh marked this pull request as ready for review July 17, 2024 18:05
@RahulGautamSingh RahulGautamSingh marked this pull request as draft July 17, 2024 18:23
@RahulGautamSingh

This comment was marked as outdated.

Sign in to view
@RahulGautamSingh RahulGautamSingh marked this pull request as ready for review July 17, 2024 18:51
@RahulGautamSingh RahulGautamSingh requested review from viceice, HonkingGoose, rarkins and secustor and removed request for rarkins July 17, 2024 19:10
@RahulGautamSingh RahulGautamSingh changed the title refactor(lib/data): monorepo [wip] refactor(lib/data): monorepo Jul 17, 2024
@RahulGautamSingh
Copy link
Collaborator Author

RahulGautamSingh commented Jul 18, 2024 •
edited

we should create a JSON Schema for it, so it's helping users with tools like vscode

task for another pr? once all json files are added.

HonkingGoose
HonkingGoose reviewed Jul 18, 2024
View reviewed changes
lib/data/readme.md Outdated Show resolved Hide resolved
secustor
secustor reviewed Jul 18, 2024
View reviewed changes
Copy link
Collaborator

@secustor secustor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, outside of docs comment

HonkingGoose
HonkingGoose suggested changes Jul 18, 2024
View reviewed changes
Copy link
Collaborator

@HonkingGoose HonkingGoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nearly good to go! 😄

lib/data/readme.md Outdated Show resolved Hide resolved
@RahulGautamSingh @HonkingGoose
Update lib/data/readme.md
6892152 
Co-authored-by: HonkingGoose <[email protected]>
HonkingGoose
HonkingGoose approved these changes Jul 18, 2024
View reviewed changes
Copy link
Collaborator

@HonkingGoose HonkingGoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with the docs now. 🥳

viceice
viceice reviewed Jul 18, 2024
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a small thing

tools/docs/presets.ts Outdated Show resolved Hide resolved
tools/docs/presets.ts Outdated Show resolved Hide resolved
@secustor secustor added this pull request to the merge queue Jul 19, 2024
Merged via the queue into renovatebot:main with commit 3384e68 Jul 19, 2024
38 checks passed
@renovate-release
Copy link
Collaborator

🎉 This issue has been resolved in version 37.434.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@viceice viceice viceice approved these changes

@secustor secustor secustor approved these changes

@HonkingGoose HonkingGoose HonkingGoose approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@RahulGautamSingh @renovate-release @viceice @secustor @HonkingGoose