-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(manager): add sveltos manager #30087
base: main
Are you sure you want to change the base?
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Package manager details can be found here: #30090 (comment) |
c7b2ba4
to
979cd3d
Compare
36f2170
to
fcaf6ef
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: Oliver Bähler <[email protected]>
e0ca135
to
2d79c49
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Is this ready for another review? BTW It isn't necessary to merge main if there are no conflicts. |
@secustor Yes this is ready for review, Sorry! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs code coverage ( see the failing CI ) and docs changes requested by @HonkingGoose
Co-authored-by: HonkingGoose <[email protected]>
Co-authored-by: HonkingGoose <[email protected]>
Co-authored-by: HonkingGoose <[email protected]>
Co-authored-by: HonkingGoose <[email protected]>
Co-authored-by: HonkingGoose <[email protected]>
Co-authored-by: Michael Kriese <[email protected]>
Co-authored-by: Michael Kriese <[email protected]>
Co-authored-by: Michael Kriese <[email protected]>
Signed-off-by: Oliver Bähler <[email protected]>
Signed-off-by: Oliver Bähler <[email protected]>
Signed-off-by: Oliver Bähler <[email protected]>
Signed-off-by: Oliver Bähler <[email protected]>
Co-authored-by: Michael Kriese <[email protected]>
Signed-off-by: Oliver Bähler <[email protected]>
Signed-off-by: Oliver Bähler <[email protected]>
Signed-off-by: Oliver Bähler <[email protected]>
Co-authored-by: Sebastian Poxhofer <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are missing coverage.
Hi I am sorry I am unable to get the coverage up :( . Can I somehow create the coverage locally? What i currently do is run Jest:
But i don't know how to interpret these results.. |
renovate/docs/development/local-development.md Lines 157 to 166 in 9b64288
|
Changes
This adds the manager for sveltos for GitOps managed Cluster Fleets. Essentially we have the same functionality as argoCD, so we were able to take the argocd manager and adjust the schema etc. I hope that's okay.
Context
Documentation (please check one with an [x])
Not sure if there's more?
How I've tested my work (please select one)
I have verified these changes via: