feat(bitbucket-server)!: autodetect gitAuthor if possible

[amezin]

Changes

Try to detect gitAuthor on Bitbucket Server during initialization.

Context

Unfortunately, there seems to be no API endpoint to get the information about the currently authenticated user. So I'm using an endpoint that depends on username. Actually, the endpoint depends on username slug, but the rules to convert username to slug aren't clear. So I'm just trying to pass the username as is, and hope it works. For all real usernames that I tried - it works. If it fails, the failure isn't fatal.

Documentation (please check one with an [x])

• I have updated the documentation, or
• No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

• Code inspection only, or
• Newly added/modified unit tests, or
• No unit tests but ran on a real repository, or
• Both unit tests + ran on a real repository

[rarkins]

This is a breaking change so should be part of v38

[rarkins]

I was under the impression that today it falls back to [email protected] for Bitbucket Server if not configured, but is that the case? I'm not seeing evidence of that in the code

[amezin]

I was under the impression that today it falls back to [email protected] for Bitbucket Server if not configured, but is that the case? I'm not seeing evidence of that in the code

renovate/lib/util/git/index.ts

Line 277 in a9a1778

gitAuthor ?? 'Renovate Bot <[email protected]>',

? This function (setGitAuthor) currently receives null on bitbucket-server if not configured manually

[rarkins]

I was under the impression that today it falls back to [email protected] for Bitbucket Server if not configured, but is that the case? I'm not seeing evidence of that in the code

renovate/lib/util/git/index.ts

Line 277 in a9a1778

gitAuthor ?? 'Renovate Bot <[email protected]>',

? This function (setGitAuthor) currently receives null on bitbucket-server if not configured manually

That's the one - I had misremembered the default bot value. I think we need to have that as gitIgnoredAuthors in such cases, to assist bitbucket server users who ran prior to v38

[amezin]

I think we need to have that as gitIgnoredAuthors in such cases, to assist bitbucket server users who ran prior to v38

Do you mean "add it automatically to the config after successful autodetect on bitbucket-server"?

[rarkins]

Still needs gitIgnoredAuthors set too

[viceice]

See reopened conversation

[viceice]

@rarkins I don't see any breaking changes. 🤔

[rarkins]

@amezin can you try undoing your last commit and trying again?

[amezin]

@amezin can you try undoing your last commit and trying again?

I don't get how it should help (and what exactly you mean).

I can rebase this PR on top of new v38 and force-push.

[rarkins]

Anything you can do to de-conflict would work

[rarkins]

I think a change in fit author is breaking because users may have settings based on it

[viceice]

needs interactive rebase onto v38