-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add datasource for AWS Lambda Layers #28251
base: main
Are you sure you want to change the base?
feat: add datasource for AWS Lambda Layers #28251
Conversation
Co-authored-by: HonkingGoose <[email protected]>
…ed-arn-datasource
…apag-Lloyd/renovate into kayma/add-aws-versioned-arn-datasource
…oned-arn-datasource
Reopens #19081 I stopped working on that PR because I found out that you usually do not have the
aws lambda add-layer-version-permission \
--layer-name my-layer \
--statement-id xaccount \
--action lambda:ListLayerVersions \
--principal 123456789012 \
--version-number 1 |
Still have to work on the documentation |
@kayman-mk Every time you update the branch it resets (disables) the CI approvals. It's best you don't commit to this branch unless you have changes or need to resolve a conflict |
Ah, ok. Thought it needs to be on the HEAD to be merged. Sorry. |
GitHub's merge queue ensures that it's tested against the latest main commit before merging so we don't need to update PRs individually unless there's a conflict or a high chance that another PR broke the open one |
lib/modules/datasource/aws-lambda-layer/__fixtures__/layer-filter-no-architecture.json
Outdated
Show resolved
Hide resolved
Co-authored-by: Michael Kriese <[email protected]>
…ed-arn-datasource
Co-authored-by: Michael Kriese <[email protected]>
…ub.com/Hapag-Lloyd/renovate into kayma/add-aws-versioned-arn-datasource
Still struggeling with the |
}); | ||
|
||
describe('getReleases', () => { | ||
it('should throw an exception if the filter criteria does not match the schema', async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@viceice Is this assumption correct? If not: how to catch this error?
try {
FilterParser.parse(xxxx);
} catch (e) {
// log error and return null
}
Looks ugly and I guess there is a better option. Checking the existing source, I didn't find any.
Changes
This PR adds a new datasource to update the versioned layer arns for AWS Lambda Layers.
Context
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: