Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add datasource for AWS Lambda Layers #28251

Open
wants to merge 86 commits into
base: main
Choose a base branch
from

Conversation

kayman-mk
Copy link

@kayman-mk kayman-mk commented Apr 5, 2024

Changes

This PR adds a new datasource to update the versioned layer arns for AWS Lambda Layers.

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

kayman-mk and others added 28 commits November 22, 2022 09:14
…apag-Lloyd/renovate into kayma/add-aws-versioned-arn-datasource
@kayman-mk
Copy link
Author

kayman-mk commented Apr 5, 2024

Reopens #19081

I stopped working on that PR because I found out that you usually do not have the lambda:listLayerVersion policy for layers you do not own. So I thought this whole datasource didn't make any sense. But in fact it is useful as we found out in a team internal discussion today:

  • you can use it to update lambda layers you own
  • you can ask the maintainer of the layer you do not own to add the respective permission so Renovate can list the version numbers as well
aws lambda add-layer-version-permission \
    --layer-name my-layer \
    --statement-id xaccount \
    --action lambda:ListLayerVersions  \
    --principal 123456789012 \
    --version-number 1

@kayman-mk
Copy link
Author

Still have to work on the documentation

@rarkins
Copy link
Collaborator

rarkins commented Aug 16, 2024

@kayman-mk Every time you update the branch it resets (disables) the CI approvals. It's best you don't commit to this branch unless you have changes or need to resolve a conflict

@kayman-mk
Copy link
Author

Ah, ok. Thought it needs to be on the HEAD to be merged. Sorry.

@rarkins
Copy link
Collaborator

rarkins commented Aug 16, 2024

GitHub's merge queue ensures that it's tested against the latest main commit before merging so we don't need to update PRs individually unless there's a conflict or a high chance that another PR broke the open one

@kayman-mk
Copy link
Author

Still struggeling with the pnpm-lock.yaml. How can I regenerate the file so it includes my changes?

});

describe('getReleases', () => {
it('should throw an exception if the filter criteria does not match the schema', async () => {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@viceice Is this assumption correct? If not: how to catch this error?

try {
  FilterParser.parse(xxxx);
} catch (e) {
  // log error and return null
}

Looks ugly and I guess there is a better option. Checking the existing source, I didn't find any.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants