Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(presets): add mui-x to material ui preset #26470

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

dulmandakh
Copy link
Contributor

@dulmandakh dulmandakh commented Jan 2, 2024

Changes

Add MUI-X to Material UI monorepo preset.

Context

MUI-X is commercial extension to the Material UI, thus better be updated as monorepo instead of separate PRs.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@dulmandakh dulmandakh changed the title add mui-x to material ui feat(presets): add mui-x to material ui preset Jan 2, 2024
@rarkins rarkins enabled auto-merge January 2, 2024 07:54
@rarkins rarkins added this pull request to the merge queue Jan 2, 2024
Merged via the queue into renovatebot:main with commit b4dd814 Jan 2, 2024
36 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.116.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

zT-1337 pushed a commit to scm-manager/renovate that referenced this pull request Jan 22, 2024
zT-1337 pushed a commit to scm-manager/renovate that referenced this pull request Jan 24, 2024
zT-1337 pushed a commit to scm-manager/renovate that referenced this pull request Jan 24, 2024
@oliviertassinari
Copy link
Contributor

oliviertassinari commented Jan 25, 2024

MUI-X is commercial extension to the Material UI, thus better be updated as monorepo instead of separate PRs.

A precision. MUI X is a different project (open-core) than Material UI (open-source), they don't follow the same versioning strategy. MUI X has a built-in wrapper for Material UI, will also come with an unstyled version of the component. And we plan to support other UI libraries with it.

@dulmandakh
Copy link
Contributor Author

dulmandakh commented Jan 25, 2024

@oliviertassinari first of all, thank for you MUI and MUI-X.

We use date picker and data grid components from MUI-X, then MUI-X packages install MUI packages as dependency. IIRC, we had a case where we used date picker pro, then Renovate created separate PRs for MUI-X and MUI packages. So I thought that this case would better be handled as single update, thus created this PR.

@oliviertassinari
Copy link
Contributor

@dulmandakh this makes sense to me, there is likely to be coherence with the changes 👍

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants