-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(presets)!: drop renovate.json
fallback
#23910
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Outside of coverage LGTM
Also not approving as it targeted at the main branch ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nabeelsaabna can you find out how many Fallback to renovate.json file as a preset is deprecated, please use a default.json file instead.
log messages we see daily in the hosted app?
@viceice we may want to upgrade this to a WARN for a longer period of time first
@rarkins in the last 7 days we have 4234 unique repositories with this message in the github hosted app |
e9edf06
to
70013a8
Compare
ok I've created another PR to warn now, so we can drop later |
I don't think we can do this yet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we have too many still using this in the Renovate app.
so what's the next step to get existing users to change their settings? |
We could improve our efficiency by remembering these fallbacks in repositoryCache: #28008 |
I'm not sure we can merge this for a long time, certainly not in v38. So let's close this PR but keep the branch in place |
Changes
Remove the fallback to
renovate.json
preset whendefault.json
is not found.NOTE: Review with ignore whitespace changes. 😉
TODO
Context
renovate.json
fallback #24263Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: