Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update rebaseWhen docs and update text in Renovate PR body #8988

Closed
1 of 2 tasks
HonkingGoose opened this issue Mar 4, 2021 · 4 comments · Fixed by #9031
Closed
1 of 2 tasks

update rebaseWhen docs and update text in Renovate PR body #8988

HonkingGoose opened this issue Mar 4, 2021 · 4 comments · Fixed by #9031
Assignees
Labels
priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others status:requirements Full requirements are not yet known, so implementation should not be started type:feature Feature (new functionality)

Comments

@HonkingGoose
Copy link
Collaborator

HonkingGoose commented Mar 4, 2021

What would you like Renovate to be able to do?

I'm rescuing this from the discussion (#8982) to prevent this from being missed later on.

As far as I can see from the discussion there, there's a problem with the current descriptions in the docs on rebaseWhen.

It seems that the docs are not up-to-date with the current behavior of the bot anymore, as @viceice explained:

default is rebaseWhen=auto which will rebase all automerge pr's / branches by default. All other are only rebased on conflict.

This is the recent change we made. so renovate is able to rebase automerge pr, so it's not stopped by up-to-date branch protection

@rarkins also said that:

We should make sure that the description in the PR matches as well, to explain that stale rebasing is necessary if automerge is enabled.

Did you already have any implementation ideas?

@HonkingGoose HonkingGoose added priority-5-triage status:requirements Full requirements are not yet known, so implementation should not be started type:feature Feature (new functionality) labels Mar 4, 2021
@HonkingGoose
Copy link
Collaborator Author

@rarkins and @viceice I'm not totally clear on what needs changing here, so feel free to expand on the requirements.

@HonkingGoose HonkingGoose added priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others and removed priority-5-triage labels Mar 7, 2021
@HonkingGoose
Copy link
Collaborator Author

Putting this at priority-3-normal as what we have now seems to confuse our users. 😄

#8982 (reply in thread)

@HonkingGoose
Copy link
Collaborator Author

Question for @rarkins: didn't you also want to update the Renovate bot PR body text? I noticed you've closed this issue with PR #9031 but that was a docs: change only.

@renovate-release
Copy link
Collaborator

🎉 This issue has been resolved in version 24.77.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others status:requirements Full requirements are not yet known, so implementation should not be started type:feature Feature (new functionality)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants