Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm values updates are ignored during successive runs when bumpVersion is enabled #8919

Closed
1 of 5 tasks
chgl opened this issue Mar 1, 2021 · 4 comments
Closed
1 of 5 tasks
Labels
priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:bug Bug fix of existing functionality

Comments

@chgl
Copy link
Contributor

chgl commented Mar 1, 2021

What Renovate type, platform and version are you using?

Renovate GitHub App.

Describe the bug

If bumpVersion is enabled and the helm-values manager attempts to update an image version in values.yaml and additionally tries to bump the Chart.yaml when updating a helm chart, there seems to be an ordering issue where sometimes both files are correctly updated and sometimes just the Chart.yaml version bump is applied.

For example, in my helm chart repo there are currently 2 PRs open which update helm-values. Renovate is configured to bumpVersion in the Chart.yaml as well: https://github.com/chgl/charts/pulls.

  1. https://github.com/chgl/charts/pull/40/files
    incorrectly just bumps the Chart.yaml:

    image

  2. https://github.com/chgl/charts/pull/45/files
    correctly updates both Chart.yaml and values.yaml:

    image

However, I noticed that renovate tries to constantly update both PRs and everytime it does, the "correctness" of the PR is swapped, ie. the next time renovate will run, chgl/charts#40 will be corrected to update both files and chgl/charts#45 will only update the Chart.yaml ( - which just happened as I was typing).

Note that this is definitely a result of something I messed up in #8240. We could revert 662a60a for now to fix it. I can't quite figure out what I did wrong, but at least I can reproduce it to some extent.

Relevant debug logs

renovate-logs-310092033.txt

Have you created a minimal reproduction repository?

In https://github.com/chgl/charts/pulls the two PRs 40 and 45 flip-flop between being correctly updated and missing the values.yaml update.

Please read the minimal reproductions documentation to learn how to make a good minimal reproduction repository.

  • This is a really small bug, it does not need a reproduction (think small typo)
  • I have provided a minimal reproduction repository
  • I don't have time for that, but it happens in a public repository I have linked to
  • I don't have time for that, and cannot share my private repository
  • The nature of this bug means it's impossible to reproduce publicly

Additional context

I think it's something I didn't consider in

if (res === packageFileContent) {
when updating values.yaml. If it runs correctly, the logs show "Contents updated" for the values.yaml file.

@chgl chgl added status:requirements Full requirements are not yet known, so implementation should not be started type:bug Bug fix of existing functionality labels Mar 1, 2021
chgl added a commit to chgl/charts that referenced this issue Mar 1, 2021
@rarkins
Copy link
Collaborator

rarkins commented Mar 1, 2021

I'm reverting it in PR #8926 as I can't work out what could be causing this behavior. Can you resubmit the feature with fix in a new PR if/once you work it out?

@chgl
Copy link
Contributor Author

chgl commented Mar 1, 2021

I will! Thank you!

@HonkingGoose HonkingGoose added the priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others label Mar 3, 2021
@PrivatePuffin
Copy link

@chgl Nice work on the issue report, looking forward to your renewed PR!

@viceice
Copy link
Member

viceice commented Mar 7, 2021

closing this in favor of #8231

@viceice viceice closed this as completed Mar 7, 2021
@viceice viceice removed the status:requirements Full requirements are not yet known, so implementation should not be started label Mar 7, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:bug Bug fix of existing functionality
Projects
None yet
Development

No branches or pull requests

5 participants