-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(helm-values): Support for bumpVersion #8240
feat(helm-values): Support for bumpVersion #8240
Conversation
…upport-to-helm-values
Because there isn't yet any non-autoreplace manager to test this with.
…upport-to-helm-values
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small types change
A potential problem in future (not affecting this functionality I think) is that the |
Agreed! In this case, the helmv3 manager is able to bump the version of Chart.yaml as well, however since Is there anything else I could improve or address for this PR? |
🎉 This PR is included in version 24.67.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Changes:
Implements the
bumpPackageVersion
interface for thehelm-values
manager. Becausehelm-values
' packageFile is different from the file containing the version to be bumped (theChart.yaml
) this required adding support for decoupling the two. For now, only one additionalbumpVersionPackageFile
is supported, if the need arises it would probably be cleanest to provide a list of files that will need to be updated should the version be bumped.I've tested it in the repo here: https://github.com/chgl/renovate-helm-values-bumpversion-test/pull/5/files and it seems to work.
Context:
Closes #8231
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: