Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace enabled:false with skipReason:x #6916

Open
rarkins opened this issue Aug 5, 2020 · 1 comment
Open

Replace enabled:false with skipReason:x #6916

rarkins opened this issue Aug 5, 2020 · 1 comment
Labels
priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:feature Feature (new functionality)

Comments

@rarkins
Copy link
Collaborator

rarkins commented Aug 5, 2020

What would you like Renovate to be able to do?

In most cases users would benefit from knowing "why" dependencies or updates were skipped. Perhaps we should encourage the use of skipReason with a free text value instead of enabled:false?

Did you already have any implementation ideas?

We could replace all our internal enabled: false with descriptive skipReason values. We could also massage people's configs to change enabled: false to skipReason: "disabled" or skipReason: "disabled by packageRules".

I'm also considering whether we could even include a skipReason for every matched fileMatch result, such as:

  • ignorePaths (if the fileMatch has a hit but so does ignorePaths)
  • no dependencies (if the manager finds no dependencies)
  • parsing failure (if manager can't parse the file)
    etc.

The main idea is bringing more visibility, and such results could also be put into a dependencies dashboard.

I've also experienced that some users find "enabled: false" to be unintuitive (because of the negative nature of it I guess).

Are there any workarounds or alternative ideas you've tried to avoid needing this feature?

This is a nice-to-have, the current way works but is not as readable.

Is this a feature you'd be interested in implementing yourself?

Maybe

@rarkins rarkins added type:feature Feature (new functionality) priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others labels Aug 5, 2020
@viceice
Copy link
Member

viceice commented Aug 5, 2020

Good idea, this would really help while searching the logs.

@rarkins rarkins added the status:requirements Full requirements are not yet known, so implementation should not be started label Jan 12, 2021
@rarkins rarkins added status:ready and removed status:requirements Full requirements are not yet known, so implementation should not be started labels Apr 21, 2023
rarkins added a commit that referenced this issue May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:feature Feature (new functionality)
Projects
None yet
Development

No branches or pull requests

2 participants