Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bellsoft/liberica-runtime-container to workarounds:javaLTSVersions #31071

Closed
HonkingGoose opened this issue Aug 28, 2024 · 3 comments · Fixed by #31082
Closed

Add bellsoft/liberica-runtime-container to workarounds:javaLTSVersions #31071

HonkingGoose opened this issue Aug 28, 2024 · 3 comments · Fixed by #31082
Assignees
Labels
core:config Related to config capabilities and presets good first issue Suitable for new contributors help wanted Help is needed or welcomed on this issue priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:feature Feature (new functionality)

Comments

@HonkingGoose
Copy link
Collaborator

HonkingGoose commented Aug 28, 2024

Describe the proposed change(s).

Add bellsoft/liberica-runtime-container image to workarounds:javaLTSVersions preset.

Only copy/paste the needed bits from the full config below. 😉

    {
      "description": "Enable JDK updates of bellsoft/liberica-runtime-container.",
      "matchCurrentValue": "/^jdk-/",
      "matchDatasources": [
        "docker"
      ],
      "matchPackageNames": [
        "bellsoft/liberica-runtime-container"
      ],
      "versioning": "regex:^jdk-(?<major>\\d+)?(\\.(?<minor>\\d+))?(\\.(?<patch>\\d+))?([\\._+](?<build>(\\d\\.?)+))?(-(?<compatibility>.*))?$"
    },
    {
      "description": "Enable JRE updates of bellsoft/liberica-runtime-container.",
      "matchCurrentValue": "/^jre-/",
      "matchDatasources": [
        "docker"
      ],
      "matchPackageNames": [
        "bellsoft/liberica-runtime-container"
      ],
      "versioning": "regex:^jre-(?<major>\\d+)?(\\.(?<minor>\\d+))?(\\.(?<patch>\\d+))?([\\._+](?<build>(\\d\\.?)+))?(-(?<compatibility>.*))?$"
    },
    {
      "allowedVersions": "/^(jdk|jre)-(?:8|11|17|21)(?:\\.|-|$)/",
      "description": "Limit bellsoft/liberica-runtime-container versions to LTS releases.",
      "matchDatasources": [
        "docker"
      ],
      "matchPackageNames": [
        "bellsoft/liberica-runtime-container"
      ]
    }

Source:

@HonkingGoose HonkingGoose added type:feature Feature (new functionality) help wanted Help is needed or welcomed on this issue priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others good first issue Suitable for new contributors core:config Related to config capabilities and presets labels Aug 28, 2024
@mvitz
Copy link
Contributor

mvitz commented Aug 28, 2024

@HonkingGoose thanks for converting my question/answer into this issue.
I'll implement that today and create a PR for that.

I have just one additional question.

Technically, the config above contains two parts.
The first two are required to enable correct updates for the Docker Image because it contains two variable parts within the label, and the third one is a limitation to only update to long-term support (LTS) versions.
Therefore, the third part could be merged into the existing workarounds:javaLTSVersions preset.
However, the first two are required to be in place even when I want to update to non LTS versions and therefore exclude the workarounds:javaLTSVersions preset from my config.
Should these two be placed in its own preset (maybe a little bit like workarounds:nodeDockerVersioning)?

@HonkingGoose
Copy link
Collaborator Author

Where to put the base parts?

However, the first two [parts] are required to be in place even when I want to update to non-LTS versions and therefore exclude the workarounds:javaLTSVersions preset from my config.
Should these two be placed in its own preset (maybe a little bit like workarounds:nodeDockerVersioning)?

Putting the two base parts in a new preset seems best. Then we can extend from the basic preset in the workarounds:javaLTSVersions.

I don't know if that preset should be group:, monorepo: or something else. @rarkins what do you prefer?

Thank you for working on the issue

@HonkingGoose thanks for converting my question/answer into this issue.
I'll implement that today and create a PR for that.

Thank you! ❤️

@renovate-release
Copy link
Collaborator

🎉 This issue has been resolved in version 38.63.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core:config Related to config capabilities and presets good first issue Suitable for new contributors help wanted Help is needed or welcomed on this issue priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:feature Feature (new functionality)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants