Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename renovate/stability-days status check to renovate/minimum-release-age #21442

Open
1 of 3 tasks
HonkingGoose opened this issue Apr 12, 2023 · 4 comments
Open
1 of 3 tasks
Labels
breaking Breaking change, requires major version bump priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others status:blocked Issue is blocked by another issue or external requirement type:feature Feature (new functionality)
Milestone

Comments

@HonkingGoose
Copy link
Collaborator

HonkingGoose commented Apr 12, 2023

Describe the proposed change(s).

Creating an issue to track this idea.

Original comments leading to this issue

Document that the minimumReleaseAge config option causes a renovate/stabilityDays option to be added. This would be very unintuitive to new users of the feature otherwise.

Is changing the renovate/stability-days status check to renovate/minimum-release-age also planned? I know that it would have to be done separately as it would be a breaking change

Planned but I don't think we have an issue yet. I would like to think if it's the right time to let users customize Renovate's status check strings too

Originally posted by @rarkins in #21376 (comment)

Todos:

Related issue

@HonkingGoose HonkingGoose added type:refactor Refactoring or improving of existing code status:requirements Full requirements are not yet known, so implementation should not be started priority-5-triage labels Apr 12, 2023
@HonkingGoose HonkingGoose added priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others and removed priority-5-triage labels Apr 12, 2023
@rarkins rarkins added type:feature Feature (new functionality) breaking Breaking change, requires major version bump and removed type:refactor Refactoring or improving of existing code labels Apr 12, 2023
@HonkingGoose
Copy link
Collaborator Author

HonkingGoose commented Apr 17, 2023

@rarkins want me to split the "customize Renovate's status check strings" thing into it's own issue? That way we can refactor the name in one issue, and improve the feature in another issue. 😄


Edit, see:

@rarkins
Copy link
Collaborator

rarkins commented Apr 17, 2023

Yes, good idea

@HonkingGoose HonkingGoose changed the title Change the renovate/stability-days status check to renovate/minimum-release-age Rename renovate/stability-days status check to renovate/minimum-release-age Jun 5, 2023
@rarkins rarkins self-assigned this Jun 12, 2023
@rarkins rarkins added status:in-progress Someone is working on implementation and removed status:requirements Full requirements are not yet known, so implementation should not be started labels Jun 12, 2023
@rarkins rarkins added status:blocked Issue is blocked by another issue or external requirement and removed status:in-progress Someone is working on implementation labels Jun 27, 2023
@rarkins rarkins removed their assignment Jun 27, 2023
@HonkingGoose
Copy link
Collaborator Author

@rarkins can you explain why you labeled this issue status:blocked? I read #22704, but that does not explain things for me.

@rarkins
Copy link
Collaborator

rarkins commented Jul 5, 2023

Blocked by #19980

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking change, requires major version bump priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others status:blocked Issue is blocked by another issue or external requirement type:feature Feature (new functionality)
Projects
None yet
Development

No branches or pull requests

4 participants
@viceice @rarkins @HonkingGoose and others