Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Update dependency ruby" don't update gemfile #15114

Closed
gagalago opened this issue Apr 14, 2022 · 14 comments · Fixed by #15139 or #27451
Closed

"Update dependency ruby" don't update gemfile #15114

gagalago opened this issue Apr 14, 2022 · 14 comments · Fixed by #15139 or #27451
Assignees
Labels
manager:bundler Bundler (Ruby) package manager priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others status:in-progress Someone is working on implementation type:feature Feature (new functionality)

Comments

@gagalago
Copy link

How are you running Renovate?

WhiteSource Renovate hosted app on github.com

If you're self-hosting Renovate, tell us what version of Renovate you run.

No response

Please select which platform you are using if self-hosting.

No response

If you're self-hosting Renovate, tell us what version of the platform you run.

No response

Was this something which used to work for you, and then stopped?

I never saw this working

Describe the bug

with the update of ruby renovate does the following on my repository:

Package Type Update Change
ruby (source) patch 3.1.1 -> 3.1.2
ruby final patch 3.1.1-alpine -> 3.1.2-alpine
ruby stage patch 3.1.1-alpine -> 3.1.2-alpine

but that's not enough as we have also to update the gemfile ruby version (the gemfile.lock need to be updated accordingly also)

Relevant debug logs

Logs
DEBUG: getBranchPr(renovate/ruby-3.x)(branch="renovate/ruby-3.x")
DEBUG: findPr(renovate/ruby-3.x, undefined, open)(branch="renovate/ruby-3.x")
DEBUG: findPr(renovate/ruby-3.x, undefined, closed)(branch="renovate/ruby-3.x")
DEBUG: branchExists=false(branch="renovate/ruby-3.x")
DEBUG: dependencyDashboardCheck=undefined(branch="renovate/ruby-3.x")
DEBUG: recreateClosed is false(branch="renovate/ruby-3.x")
DEBUG: findPr(renovate/ruby-3.x, Update dependency ruby to v3.1.2, !open)(branch="renovate/ruby-3.x")
DEBUG: prAlreadyExisted=false(branch="renovate/ruby-3.x")
DEBUG: Checking schedule(at any time, null)(branch="renovate/ruby-3.x")
DEBUG: No schedule defined(branch="renovate/ruby-3.x")
DEBUG: Branch needs creating(branch="renovate/ruby-3.x")
DEBUG: Using reuseExistingBranch: false(branch="renovate/ruby-3.x")
DEBUG: manager.getUpdatedPackageFiles() reuseExistinbranch=false(branch="renovate/ruby-3.x")
DEBUG: Starting search at index 0(packageFile=".ruby-version", branch="renovate/ruby-3.x")
{
  "depName": "ruby"
}
DEBUG: Found match at index 0(packageFile=".ruby-version", branch="renovate/ruby-3.x")
{
  "depName": "ruby"
}
DEBUG: Contents updated(packageFile=".ruby-version", branch="renovate/ruby-3.x")
{
  "depName": "ruby"
}
DEBUG: Updated 1 package files(branch="renovate/ruby-3.x")
DEBUG: No updated lock files in branch(branch="renovate/ruby-3.x")
DEBUG: 1 file(s) to commit(branch="renovate/ruby-3.x")
DEBUG: Preparing files for committing to branch renovate/ruby-3.x(branch="renovate/ruby-3.x")

Have you created a minimal reproduction repository?

No reproduction repository

@gagalago gagalago added priority-5-triage status:requirements Full requirements are not yet known, so implementation should not be started type:bug Bug fix of existing functionality labels Apr 14, 2022
@rarkins rarkins added the auto:reproduction A minimal reproduction is necessary to proceed label Apr 14, 2022
@github-actions
Copy link
Contributor

Hi there,

Help us by making a minimal reproduction repository.

Before we can start work on your issue we first need to know exactly what's causing the current behavior. A minimal reproduction helps us with this.

To get started, please read our guide on creating a minimal reproduction to understand what is needed.

We may close the issue if you (or someone else) have not provided a minimal reproduction within two weeks. If you need more time, or are stuck, please ask for help or more time in a comment.

Good luck,

The Renovate team

@xmunoz
Copy link

xmunoz commented Apr 14, 2022

This is also affecting us over at https://github.com/DARIAEngineering/dcaf_case_management. I'll see if I can create that minimal repro for ya.

@xmunoz
Copy link

xmunoz commented Apr 14, 2022

@viceice
Copy link
Member

viceice commented Apr 15, 2022

looks like this is easy to solve. we need to extract the version in bundler manager and call bundler lock after that.

@viceice viceice added reproduction:confirmed manager:bundler Bundler (Ruby) package manager and removed auto:reproduction A minimal reproduction is necessary to proceed labels Apr 15, 2022
@rarkins
Copy link
Collaborator

rarkins commented Apr 15, 2022

Should we extract the version in Gemfile.lock as a dependency so that we can upgrade it even if no other Ruby version files are present? Should make triggering the artifacts update easier too.

@viceice
Copy link
Member

viceice commented Apr 15, 2022

we should prefer the value in Gemfile, as the value in lockfile has a patch suffix

Gemfile.lock

 ​   ​ruby 2.7.2p137

@rarkins
Copy link
Collaborator

rarkins commented Apr 15, 2022

I agree, Gemfile is best. I wasn't sure that it's always in there though?

@viceice
Copy link
Member

viceice commented Apr 15, 2022

forked to https://github.com/renovate-reproductions/renovate-minimal-repro

@rarkins We already extract the ruby version from Gemfile as contraint, so we should simply add as dependency. Will start working on this now.

@viceice viceice self-assigned this Apr 15, 2022
@viceice viceice added priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others status:in-progress Someone is working on implementation type:feature Feature (new functionality) and removed status:requirements Full requirements are not yet known, so implementation should not be started priority-5-triage type:bug Bug fix of existing functionality labels Apr 15, 2022
@viceice
Copy link
Member

viceice commented Apr 15, 2022

switched to feature, as this is not a bug. it's simply not supported yet 😉

@viceice
Copy link
Member

viceice commented Apr 15, 2022

@viceice
Copy link
Member

viceice commented Apr 16, 2022

@renovate-release
Copy link
Collaborator

🎉 This issue has been resolved in version 32.25.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@xmunoz
Copy link

xmunoz commented Apr 16, 2022

Wow, thanks for the quick turn around! Happy holidays!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 17, 2022
benlangfeld added a commit to benlangfeld/renovate that referenced this issue Feb 20, 2024
@renovate-release
Copy link
Collaborator

🎉 This issue has been resolved in version 37.202.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
manager:bundler Bundler (Ruby) package manager priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others status:in-progress Someone is working on implementation type:feature Feature (new functionality)
Projects
None yet
5 participants