Skip to content

Commit

Permalink
refactor(terraform-provider): Use single cache namespace (#31054)
Browse files Browse the repository at this point in the history
  • Loading branch information
zharinov committed Aug 28, 2024
1 parent 523d80e commit bedddd1
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 16 deletions.
21 changes: 11 additions & 10 deletions lib/modules/datasource/terraform-provider/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -51,10 +51,11 @@ export class TerraformProviderDatasource extends TerraformDatasource {

@cache({
namespace: `datasource-${TerraformProviderDatasource.id}`,
key: (getReleasesConfig: GetReleasesConfig) =>
`${
getReleasesConfig.registryUrl
}/${TerraformProviderDatasource.getRepository(getReleasesConfig)}`,
key: (getReleasesConfig: GetReleasesConfig) => {
const url = getReleasesConfig.registryUrl;
const repo = TerraformProviderDatasource.getRepository(getReleasesConfig);
return `getReleases:${url}/${repo}`;
},
})
async getReleases({
packageName,
Expand Down Expand Up @@ -186,9 +187,9 @@ export class TerraformProviderDatasource extends TerraformDatasource {
}

@cache({
namespace: `datasource-${TerraformProviderDatasource.id}-builds`,
namespace: `datasource-${TerraformProviderDatasource.id}`,
key: (registryURL: string, repository: string, version: string) =>
`${registryURL}/${repository}/${version}`,
`getBuilds:${registryURL}/${repository}/${version}`,
})
async getBuilds(
registryURL: string,
Expand Down Expand Up @@ -288,8 +289,8 @@ export class TerraformProviderDatasource extends TerraformDatasource {
}

@cache({
namespace: `datasource-${TerraformProviderDatasource.id}-zip-hashes`,
key: (zipHashUrl: string) => zipHashUrl,
namespace: `datasource-${TerraformProviderDatasource.id}`,
key: (zipHashUrl: string) => `getZipHashes:${zipHashUrl}`,
})
async getZipHashes(zipHashUrl: string): Promise<string[] | undefined> {
// The hashes are formatted as the result of sha256sum in plain text, each line: <hash>\t<filename>
Expand All @@ -315,9 +316,9 @@ export class TerraformProviderDatasource extends TerraformDatasource {
}

@cache({
namespace: `datasource-${TerraformProviderDatasource.id}-releaseBackendIndex`,
namespace: `datasource-${TerraformProviderDatasource.id}`,
key: (backendLookUpName: string, version: string) =>
`${backendLookUpName}/${version}`,
`getReleaseBackendIndex:${backendLookUpName}/${version}`,
})
async getReleaseBackendIndex(
backendLookUpName: string,
Expand Down
4 changes: 2 additions & 2 deletions lib/modules/manager/terraform/lockfile/hash.ts
Original file line number Diff line number Diff line change
Expand Up @@ -107,8 +107,8 @@ export class TerraformProviderHash {
}

@cache({
namespace: `datasource-terraform-provider-hash`,
key: (build: TerraformBuild) => build.url,
namespace: `terraform-provider-hash`,
key: (build: TerraformBuild) => `calculateSingleHash:${build.url}`,
ttlMinutes: TerraformProviderHash.hashCacheTTL,
})
static async calculateSingleHash(
Expand Down
5 changes: 1 addition & 4 deletions lib/util/cache/package/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -90,17 +90,14 @@ export type PackageCacheNamespace =
| 'datasource-ruby-version'
| 'datasource-rubygems'
| 'datasource-terraform-module'
| 'datasource-terraform-provider-hash'
| 'datasource-terraform-provider-builds'
| 'datasource-terraform-provider-releaseBackendIndex'
| 'datasource-terraform-provider-zip-hashes'
| 'datasource-terraform-provider'
| 'datasource-terraform'
| 'datasource-unity3d'
| 'github-releases-datasource-v2'
| 'github-tags-datasource-v2'
| 'merge-confidence'
| 'preset'
| 'terraform-provider-hash'
| 'url-sha256';

export type CombinedKey = `global%%${PackageCacheNamespace}%%${string}`;

0 comments on commit bedddd1

Please sign in to comment.