fix: Use versioning comparison for release lookup filtering (#30059)

renovatebot · Jul 7, 2024 · 5eacc5e · 5eacc5e
1 parent 06349b9
commit 5eacc5e
Show file tree

Hide file tree

Showing 2 changed files with 37 additions and 1 deletion.
diff --git a/lib/workers/repository/process/lookup/filter.spec.ts b/lib/workers/repository/process/lookup/filter.spec.ts
@@ -81,5 +81,34 @@ describe('workers/repository/process/lookup/filter', () => {
 
       expect(filteredVersions).toEqual([{ version: '1.2.3-beta' }]);
     });
+
+    it('ignores version insufficient prefixes', () => {
+      const releases = [
+        { version: '1.0.1' },
+        { version: '1.2.0' },
+        { version: '2.0.0', isDeprecated: true },
+        { version: '2.1.0' },
+      ] satisfies Release[];
+
+      const config = partial<FilterConfig>({
+        ignoreUnstable: true,
+        ignoreDeprecated: true,
+      });
+      const currentVersion = 'v1.0.1';
+      const latestVersion = 'v2.0.0';
+
+      const filteredVersions = filterVersions(
+        config,
+        currentVersion,
+        latestVersion,
+        releases,
+        versioning,
+      );
+
+      expect(filteredVersions).toEqual([
+        { version: '1.2.0' },
+        { version: '2.1.0' },
+      ]);
+    });
   });
 });
diff --git a/lib/workers/repository/process/lookup/filter.ts b/lib/workers/repository/process/lookup/filter.ts
@@ -43,7 +43,14 @@ export function filterVersions(
       versioning.isGreaterThan(r.version, currentVersion),
   );
 
-  const currentRelease = releases.find((r) => r.version === currentVersion);
+  const currentRelease = releases.find(
+    (r) =>
+      versioning.isValid(r.version) &&
+      versioning.isVersion(r.version) &&
+      versioning.isValid(currentVersion) &&
+      versioning.isVersion(currentVersion) &&
+      versioning.equals(r.version, currentVersion),
+  );
 
   // Don't upgrade from non-deprecated to deprecated
   if (ignoreDeprecated && currentRelease && !currentRelease.isDeprecated) {