New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

should return an int if there is no commission #456

Open

devo-wm wants to merge 2 commits into develop from bugfix-return-None

Collaborator

devo-wm commented Jul 25, 2024

This is causing a bug

  File "/Users/wml/Projects/work/trainingcamp-django/.venv/lib/python3.9/site-packages/vendor/processors/stripe.py", line 651, in build_subscription
    total_fee_percentage = self.calculate_fee_percentage(self.invoice.total, stripe_base_fee + stripe_recurring_fee + application_fee)
TypeError: unsupported operand type(s) for +: 'float' and 'NoneType'

Because it's returning a None


          should return an int if there is no commission

a695f38

devo-wm requested review from daviddwmd, rhimmelbauer and mgcamisa

July 25, 2024 14:38


          edited the wrong function

a381aec

daviddwmd approved these changes

View reviewed changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet