Stripe Bugfix #454

rhimmelbauer · 2024-07-11T21:46:58Z

Notes:

Added discount to the Stripe Subscription creation when trial days where enabled.

mgcamisa · 2024-07-11T23:08:00Z

src/vendor/processors/stripe.py


-        total_fee_percentage = self.calculate_fee_percentage(self.invoice.total, stripe_base_fee + stripe_recurring_fee + application_fee)
+        if hasattr(self.invoice, 'coupon_code') and self.invoice.coupon_code.count():


might be able to simplify by changing this to if hasattr(self.invoice, 'coupon_code') and coupon_code := self.invoice.coupon_code.first(): and removing the following line?

Apply a discount on the Stripe Subscription Creation

3f33f47

mgcamisa reviewed Jul 11, 2024

View reviewed changes

added walrus statement

ab21d2f

mgcamisa approved these changes Jul 12, 2024

View reviewed changes

rhimmelbauer merged commit d1bb51d into develop Jul 12, 2024
1 check passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Stripe Bugfix #454

Stripe Bugfix #454

rhimmelbauer commented Jul 11, 2024

mgcamisa Jul 11, 2024 •

edited

Loading


		total_fee_percentage = self.calculate_fee_percentage(self.invoice.total, stripe_base_fee + stripe_recurring_fee + application_fee)
		if hasattr(self.invoice, 'coupon_code') and self.invoice.coupon_code.count():

Stripe Bugfix #454

Stripe Bugfix #454

Conversation

rhimmelbauer commented Jul 11, 2024

mgcamisa Jul 11, 2024 • edited Loading

Choose a reason for hiding this comment

mgcamisa Jul 11, 2024 •

edited

Loading