Bugfix-billing-dates #450

rhimmelbauer · 2024-04-23T19:34:47Z

Notes:

Added validations on the Subscriptions model for fetching get_last_payment_date and get_next_billing_date
On the Profile model added a filter to remove any dates that are value None so that the sort won't through an exeption.

mgcamisa · 2024-04-23T21:09:39Z

src/vendor/models/profile.py

+        if not next_billing_dates:
+            return None
+
+        filtered_dates = [date for date in next_billing_dates if date is not None]


should the return case come after calculating filtered_dates? what if next_billing_dates == [None]?

if not filtered_dates: return None

mgcamisa · 2024-04-23T21:09:57Z

src/vendor/models/profile.py

+        if not last_payment_dates:
+            return None
+
+        filtered_dates = [date for date in last_payment_dates if date is not None]


same note here

rhimmelbauer added 2 commits April 23, 2024 12:32

Initial branch commit

737d3e6

version bump

c7a1ede

rhimmelbauer requested review from daviddwmd, devo-wm and mgcamisa April 23, 2024 19:36

mgcamisa reviewed Apr 23, 2024

View reviewed changes

added extra check on filtered_dates list

20667fa

mgcamisa approved these changes Apr 23, 2024

View reviewed changes

rhimmelbauer merged commit b76714c into develop Apr 24, 2024
1 check passed

rhimmelbauer deleted the bugfix-billing-dates branch April 24, 2024 20:58

Provide feedback