Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix on Zero total Invoice #429

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Bugfix on Zero total Invoice #429

merged 1 commit into from
Sep 20, 2023

Conversation

rhimmelbauer
Copy link
Collaborator

Notes:

  • When an invoice has $0 as a total it does not create a charge. To fix this I set the payment status to settled and the check if the stripe_invoice has an actual charge. If it does it sets the payment status to the corresponding stripe_charge.status

@rhimmelbauer
for zero dollar invoice there is no charge created, so by default I a…
d74055c 
…m setting the payment as settled and then checking if the invoice has a charge to check the state of the charge
@mgcamisa mgcamisa merged commit fd02ff6 into develop Sep 20, 2023
1 check passed
@mgcamisa mgcamisa deleted the stripe/bugfix-invoice-success-api branch September 20, 2023 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgcamisa mgcamisa mgcamisa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rhimmelbauer @mgcamisa