bugfixes on stripe refund call. Update on the payment model to record…

… and retrieve refunds

develop/core/tests/test_api.py

@@ -103,6 +103,14 @@ def test_partial_refund_payment_fail(self):
         response = self.client.post(url, form_data)
         self.assertIn('refund_amount', json.loads(response.content)['error'])
 
+    def test_get_payment_refund_form(self):
+        payment = Payment.objects.get(pk=1)
+        url = reverse('vendor_api:refund-payment-api', kwargs={"uuid": payment.uuid})
+
+        response = self.client.get(url)
+
+        self.assertEqual(response.status_code, 200)
+
 
 @skipIf(True, "Webhook tests are highly dependent on data in Authroizenet and local data.")
 class AuthorizeNetAPITest(TestCase):

src/vendor/forms.py

@@ -319,25 +319,21 @@ class PaymentRefundForm(forms.ModelForm):
 
     class Meta:
         model = Payment
-        fields = ["refund_amount", "reason", "void_end_date"]
+        fields = ['refund_amount', 'reason', 'void_end_date']
 
     def clean_refund_amount(self):
         past_refunds_amount = 0
-        refund_amount = self.cleaned_data.get("refund_amount", 0)
+        refund_amount = self.cleaned_data.get('refund_amount', 0)
 
         if refund_amount > self.instance.amount:
-            raise forms.ValidationError(
-                _("Refund amount cannot be greater than the original amount")
-            )
-
-        if past_refunds := self.instance.result.get("refunds", []):
+            raise forms.ValidationError(_("Refund amount cannot be greater than the original amount"))
+
+        if (past_refunds := self.instance.result.get('refunds', [])):
             for partial_refund in past_refunds:
-                past_refunds_amount += Decimal(partial_refund.get("amount", 0))
+                past_refunds_amount += Decimal(partial_refund.get('amount', 0))
 
         if (refund_amount + past_refunds_amount) > self.instance.amount:
-            raise forms.ValidationError(
-                _("Refund amount cannot be greater than the original amount")
-            )
+            raise forms.ValidationError(_("Refund amount cannot be greater than the original amount"))
 
         return refund_amount
 

src/vendor/models/payment.py

@@ -1,5 +1,6 @@
 import uuid
 
+from decimal import Decimal
 from django.db.models.aggregates import Sum
 from django.core.exceptions import MultipleObjectsReturned, ObjectDoesNotExist
 from django.db import models
@@ -9,7 +10,7 @@
 from vendor.models.receipt import Receipt
 from vendor.models.subscription import Subscription
 from vendor.models.base import SoftDeleteModelBase
-from vendor.models.choice import PurchaseStatus
+from vendor.models.choice import PurchaseStatus, RefundReasons
 from vendor.utils import get_display_decimal
 
 
@@ -146,13 +147,43 @@ def get_receipt(self):
     def get_amount_display(self):
         return get_display_decimal(self.amount)
 
-    def record_refund(self, amount, date=timezone.now()):
+    def record_refund(self, amount, date=timezone.now(), reason=RefundReasons.OTHER.value):
         self.status = PurchaseStatus.REFUNDED
         if "refunds" not in self.result:
             self.result["refunds"] = []
 
         self.result["refunds"].append({
-            "date": date.strftime("%Y-%m-%d_%H:%M:%S"),
+            "date": date.isoformat(),
+            "reason": reason,
             "amount": str(amount)
         })
+
         self.save()
+
+    def is_refund_available(self, refund_amount):
+        past_refunds = 0
+        past_refund_amount = 0
+
+        if refund_amount > self.amount:
+            return False
+
+        if (past_refunds := self.result.get("refunds", [])):
+            past_refund_amount = sum([
+                Decimal(past_refund.get("amount", 0))
+                for past_refund in past_refunds
+            ])
+
+        if (past_refund_amount + refund_amount) > self.amount:
+            return False
+
+        return True
+
+    def get_past_refunds(self):
+        past_refunds = []
+        reasons = {reason[0]: reason[1] for reason in RefundReasons.choices}
+
+        for refund in self.result.get("refunds", []):
+            refund['reason'] = reasons[refund['reason'].lower()]
+            past_refunds.append(refund)
+
+        return past_refunds

src/vendor/processors/base.py

@@ -573,7 +573,7 @@ def subscription_update_price(self, subscription, new_price, user):
     # -------------------
     # Refund a Payment
     def refund_payment(self, refund_form, date=timezone.now()):
-        refund_form.instance.record_refund(refund_form.cleaned_data['refund_amount'], date)
+        refund_form.instance.record_refund(refund_form.cleaned_data['refund_amount'], date, refund_form.cleaned_data['reason'])
 
         if refund_form.cleaned_data['void_end_date']:
             receipt = refund_form.instance.get_receipt()

src/vendor/processors/stripe.py

@@ -685,11 +685,11 @@ def build_invoice(self, currency=DEFAULT_CURRENCY):
         }
 
     def build_refund(self, refund_form):
-        int_amount = self.convert_decimal_to_integer(amount=refund_form.cleared_data["amount"])
+        int_amount = self.convert_decimal_to_integer(refund_form.cleaned_data["refund_amount"])
         return {
-            "charge": refund_form.instance.transaction_id,
+            "charge": refund_form.instance.transaction,
             "amount": int_amount,
-            "reverse_transaction": True,
+            "reverse_transfer": True,
             "refund_application_fee": True,
             "reason": refund_form.cleaned_data['reason']
         }